commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robert burrell donkin <robertburrelldon...@blueyonder.co.uk>
Subject Re: [digester] [PATCH] Adding Ant-like properties support
Date Tue, 11 Nov 2003 21:56:49 GMT
On 11 Nov 2003, at 21:39, Craig R. McClanahan wrote:

> Quoting Remy Maucherat <remm@apache.org>:
>
>> Remy Maucherat wrote:
>>
>>> Hi,
>>>
>>> I described the feature a couple weeks ago, and here's my patch.
>>>
>>> It currently only replaces attributes processed by the setProperties
>>> rule. This did sound good enough to me. I read about processing text
>>> nodes too (does Ant do this also ?), so maybe we can improve this
>>> patch/feature more.
>>
>> BTW, I do have commit access on digester, so I can commit it myself if
>> the change is acceptable (for a first implementation).
>>
>> Remy
>>
>
> At first glance it looks fine ... I will have a little time this 
> evening to
> analyze it more thoroughly, and integrate it, if Robert doesn't beat 
> me.

the design seems fine to me. i'll probably (for once) leave the legwork 
to craig :)

(i'm *so* busy catching up right now.)

> Some unit tests to exercise the behavior would also be very helpful 
> :-).

+1

BTW i'd be happy for remy to have digester karma

- robert


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message