commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robert burrell donkin <robertburrelldon...@blueyonder.co.uk>
Subject Re: [digester] two very simple plugins patches
Date Tue, 18 Nov 2003 22:35:58 GMT
hi simon

i've committed both patches.

would you be willing to knock up a test case for the second?

- robert

On 17 Nov 2003, at 09:43, Simon Kitching wrote:

> Hi,
>
> The first attached patch is just a fix for a minor javadoc problem
> introduced in an earlier patch.
>
> ====
>
> The second patch is perhaps more controversial: it allows a leading
> slash on patterns for the PluginRules class.
>
> ie "/root/item" is treated just like "root/item".
>
> This is useful because plugin classes usually do something like this:
>   digester.add....(basePattern + "/mychildtag");
>
> If the base pattern is "", then the pattern ends up with a leading
> slash, which is not good.
>
> This patch definitely does *not* alter the behaviour of any code  
> outside
> plugins (though I think it would be nice for all the Rules classes to
> allow leading slashes anyway).
>
> Regards,
>
> Simon
> <plugins-javadoc.patch><plugins- 
> slash.patch>----------------------------------------------------------- 
> ----------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message