commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remy Maucherat <r...@apache.org>
Subject Re: [digester] [PATCH] Adding Ant-like properties support
Date Wed, 12 Nov 2003 10:01:19 GMT
Simon Kitching wrote:
> Hi Remy,
> 
> I'm really keen to have this sort of feature in Digester.
> 
> I've had this kind of functionality in my local application for some
> time now, but it's implemented in a rather different manner.
> 
> Attached is my current implementation, for comparison.
> 
> Here's the major differences:
> 
> *
> Your initial patch only does substitution for SetPropertiesRule.
> What about CallParamRule, etc?
> 
> The attached implementation automatically applies to all attributes, and
> therefore to all rules both built-in and custom. While somewhat less
> efficient than your current proposal, it isn't likely to be invoked very
> often (variable substitution is expected to be the exception, not the
> normal case). See later for a proposed optimisation to the current
> implementation.

- it could be not very efficient (you reinstantiate all attribute 
lists); JBoss does the exact same thing, and I don't know if it's 
significant, so I chose a lower overhead method; I think I'll try it 
though, since it is more generic and easier to implement
- it doesn't support scoping like Ant does (and is a feature Tomcat 
would use)
- personally, I'm used to ${...}, like all Ant users, probably; I don't 
see any reason to add support for customizing this (I don't like featurism)
- it should be easy to disable the feature, and it should be disabled by 
default
- as a result of the point above, I see zero value in escaping

Remy


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message