Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@www.apache.org Received: (qmail 20216 invoked from network); 10 Oct 2003 11:03:38 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 10 Oct 2003 11:03:38 -0000 Received: (qmail 418 invoked by uid 500); 10 Oct 2003 11:03:34 -0000 Delivered-To: apmail-jakarta-commons-dev-archive@jakarta.apache.org Received: (qmail 352 invoked by uid 500); 10 Oct 2003 11:03:33 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 338 invoked from network); 10 Oct 2003 11:03:32 -0000 Received: from unknown (HELO server2747) (212.169.185.6) by daedalus.apache.org with SMTP; 10 Oct 2003 11:03:32 -0000 Received: from eric (80.133.180.230) by server2747 with MERCUR-SMTP/POP3/IMAP4-Server (v3.30.09 AS-5242886) for ; Fri, 10 Oct 2003 13:02:15 +0200 Message-ID: <000701c38f1e$4e931a00$0101a8c0@eric> From: "Oliver Heger" To: "Jakarta Commons Developers List" References: <036c01c15174$1ec7eec0$0100a8c0@IQUITOS> Subject: Re: [configuration]HierarchicalConfiguration Date: Fri, 10 Oct 2003 13:04:41 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1106 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1106 X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Hello, I'm not sure if I understand what you mean. My problem with the addProperty() method is not caused by some kind of error a unit test could detect. It's merly a design issue. At the moment addProperty() is implemented so that it first handles stuff related to collections or string values that contain multiple property values. This is fine. But then instead of calling addPropertyDirect() it calls getPropertyDirect() and performs the adding by hand. Here it creates a Container if necessary and adds this container by calling addPropertyDirect(). This part is not compatible with my implementation and is in my opinion to much tight to a concrete mechanism of storing the properties. I could of course overwrite addProperty() in my implementation, but then I would have to copy the first part which deals with the collections. Greetings Oli ----- Original Message ----- From: "Eric Pugh" To: "'Jakarta Commons Developers List'" Sent: Wednesday, October 10, 2001 12:12 PM Subject: RE: [configuration]HierarchicalConfiguration > Can you provide a unit test that demonstrates the problem? If the problem > is because of your specific subclass, can you just create a mock version? > That way we have something firm to lookat, and then we can discuss the > pro's/con's of moving the methods around... > > Eric > --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org