commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 23593] - Add Digest facade around java.security.MessageDigest
Date Mon, 13 Oct 2003 20:44:22 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23593>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23593

Add Digest facade around java.security.MessageDigest





------- Additional Comments From apache@dave.dribin.org  2003-10-13 20:44 -------
Great, thanks for committing it.  Three minor comments.  First, we may as well
make getMd5Digest() and getShaDigest() public.  I can see using them outside of
this class.  The second comment is in regards to throwing InternalError.  This
exception is meant for internal JVM faults, which this is not.  Perhaps an
IllegalArgumentException is more acurate?  Finally, the exception context is
lost becuase exception chaining is not used.  If codec doesn't already use
commons-lang, than there's not much that can be done, I suppose.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message