commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simon Kitching <si...@ecnetwork.co.nz>
Subject Re: [digester] plugins module ready for evaluation
Date Sun, 05 Oct 2003 23:00:06 GMT
> > 
> > i'm also a bit confused why PluginDeclarationRule throws 
> > ClassNotFoundException's when require attributes are missing from the xml.
> >   this seems a wrong to me. (i've left these for the moment since it's 
> > easier for people to examine the code when it's in cvs.) there are also a 
> > few Exception's thrown. i'd prefer specific subclasses to be thrown since 
> > this allows users (if they wish) to diagnose the original problem.
> 
> Well, I chose ClassNotFound partly because the result of these mandatory
> attributes being missing is that we don't know which class to
> instantiate. Isn't that sort of like ClassNotFound? :-)
> 
> Any suggestions for superior options are welcome. I agree it could be
> improved. This code was written before the PluginInvalidInputException
> class existed; would this be more appropriate?
> 
> If there are any raw "Exception" classes being thrown, these are just
> remnants of code before cleanup and should definitely be fixed.

Attached is a patch to fix the locations where ClassNotFoundException
and Exception are being thrown. Class PluginInvalidInputException is
thrown instead.

Patch is based from digester root directory.

Regards,

Simon

Mime
View raw message