Return-Path: Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 64268 invoked by uid 500); 7 Sep 2003 08:44:57 -0000 Received: (qmail 64261 invoked from network); 7 Sep 2003 08:44:57 -0000 Received: from unknown (HELO minotaur.apache.org) (209.237.227.194) by daedalus.apache.org with SMTP; 7 Sep 2003 08:44:57 -0000 Received: (qmail 57970 invoked by uid 1529); 7 Sep 2003 08:45:16 -0000 Date: 7 Sep 2003 08:45:16 -0000 Message-ID: <20030907084516.57969.qmail@minotaur.apache.org> From: scolebourne@apache.org To: jakarta-commons-cvs@apache.org Subject: cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections CollectionUtils.java X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N scolebourne 2003/09/07 01:45:16 Modified: collections/src/java/org/apache/commons/collections CollectionUtils.java Log: Javadoc improvements bug 22964, from Janek Bogucki Revision Changes Path 1.37 +7 -8 jakarta-commons/collections/src/java/org/apache/commons/collections/CollectionUtils.java Index: CollectionUtils.java =================================================================== RCS file: /home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/CollectionUtils.java,v retrieving revision 1.36 retrieving revision 1.37 diff -u -r1.36 -r1.37 --- CollectionUtils.java 5 Sep 2003 02:16:33 -0000 1.36 +++ CollectionUtils.java 7 Sep 2003 08:45:16 -0000 1.37 @@ -87,9 +87,10 @@ * @author Paul Jack * @author Stephen Colebourne * @author Steve Downey - * @author Herve Quiroz + * @author Herve Quiroz * @author Peter KoBek * @author Matthew Hawthorne + * @author Janek Bogucki */ public class CollectionUtils { @@ -502,8 +503,6 @@ * @param inputCollection the collection to get the input from, may be null * @param predicate the predicate to use, may be null * @param outputCollection the collection to output into, may not be null - * @return the outputCollection with the the elements matching the predicate added - * @throws NullPointerException if the input collection is null */ public static void select(Collection inputCollection, Predicate predicate, Collection outputCollection) { if (inputCollection != null && predicate != null) { @@ -520,7 +519,7 @@ * Selects all elements from inputCollection which don't match the given predicate * into an output collection. *

- * A null predicate matches no elements. + * If the input predicate is null, the result is an empty list. * * @param inputCollection the collection to get the input from, may not be null * @param predicate the predicate to use, may be null @@ -536,12 +535,12 @@ /** * Selects all elements from inputCollection which don't match the given predicate * and adds them to outputCollection. + *

+ * If the input predicate is null, no elements are added to outputCollection. * * @param inputCollection the collection to get the input from, may be null * @param predicate the predicate to use, may be null * @param outputCollection the collection to output into, may not be null - * @return the outputCollection with the the elements not matching the predicate added - * @throws NullPointerException if the input collection is null */ public static void selectRejected(Collection inputCollection, Predicate predicate, Collection outputCollection) { if (inputCollection != null && predicate != null) {