Return-Path: <yan@studylink.com>
Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm
Delivered-To: mailing list commons-dev@jakarta.apache.org
Received: (qmail 6628 invoked from network); 3 Sep 2003 21:43:04 -0000
Received: from unknown (HELO localhost.localdomain) (194.222.212.136)
  by daedalus.apache.org with SMTP; 3 Sep 2003 21:43:04 -0000
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by localhost.localdomain (8.12.5/8.12.5) with ESMTP id h83MgmFZ002876
	for <commons-dev@jakarta.apache.org>; Wed, 3 Sep 2003 22:42:48 GMT
Received: (from yan@localhost)
	by localhost.localdomain (8.12.5/8.12.5/Submit) id h83Mgkex002874;
	Wed, 3 Sep 2003 22:42:46 GMT
X-Authentication-Warning: localhost.localdomain: yan set sender to
 yan@studylink.com using -f
Subject: [lang] Should IntRangeTest use variables fiveL, tenL?
From: Janek Bogucki <yan@studylink.com>
To: Jakarta Commons Developers List <commons-dev@jakarta.apache.org>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
X-Mailer: Ximian Evolution 1.0.8 (1.0.8-10) 
Date: 03 Sep 2003 22:42:46 +0000
Message-Id: <1062628966.1552.15.camel@localhost.localdomain>
Mime-Version: 1.0
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

In IntRangeTest fiveL and tenL are assigned but not used. Should the
code read:

        // test non Integer, for full coverage
        Long fiveL = new Long(5L);
        Long tenL = new Long(10L);
        assertEquals(fiveL, nr.getMinimumNumber());
        assertEquals(tenL, nr.getMaximumNumber());

This is the current version of the method in question:

    public void testConstructor2b() {
        IntRange nr = new IntRange(five, ten);
        assertSame(five, nr.getMinimumNumber());
        assertSame(ten, nr.getMaximumNumber());
        
        nr = new IntRange(ten, five);
        assertSame(five, nr.getMinimumNumber());
        assertSame(ten, nr.getMaximumNumber());
        
        nr = new IntRange(five, long10);
        assertSame(five, nr.getMinimumNumber());
        assertEquals(ten, nr.getMaximumNumber());
        
        // test non Integer, for full coverage
        Long fiveL = new Long(5L);
        Long tenL = new Long(10L);
        assertEquals(five, nr.getMinimumNumber());
        assertEquals(ten, nr.getMaximumNumber());
        
        // not null
        try {
            new IntRange(five, null);
            fail();
        } catch (IllegalArgumentException ex) {}
        try {
            new IntRange(null, five);
            fail();
        } catch (IllegalArgumentException ex) {}
        try {
            new IntRange(null, null);
            fail();
        } catch (IllegalArgumentException ex) {}
    }

-Janek