commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@codehaus.org
Subject [jira] Updated: (JELLY-77) [patch] Update jelly:util replace tag to replace entire strings
Date Sat, 06 Sep 2003 03:02:10 GMT
The following issue has been updated:

    Updater: Paul O'Fallon (mailto:paul.ofallon@cox.com)
       Date: Fri, 5 Sep 2003 10:01 PM
    Comment:
Here is a version which preserves oldChar/newChar functionality, plus does string replace
for old/new attributes.  I've also added two tests, one to validate existing functionality
(when strings longer than 1 char are passed in) and another to test the new functionality.
 Passing in an empty string for new (or newChar) leaves the original string unchanged (like
StringUtils.replace()).  Let me know if I need to do anything else.  Thanks!
    Changes:
             Attachment changed to util-replace.patch
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://jira.codehaus.org/secure/ViewIssue.jspa?key=JELLY-77&page=history

---------------------------------------------------------------------
View the issue:

  http://jira.codehaus.org/secure/ViewIssue.jspa?key=JELLY-77


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: JELLY-77
    Summary: [patch] Update jelly:util replace tag to replace entire strings
       Type: Improvement

     Status: Unassigned
   Priority: Major

 Time Spent: Unknown
  Remaining: Unknown

    Project: jelly
 Components: 
             taglib.util

   Assignee: 
   Reporter: Paul O'Fallon

    Created: Sun, 24 Aug 2003 2:25 PM
    Updated: Fri, 5 Sep 2003 10:01 PM
Environment: win xp, jdk1.3.1

Description:
The replace tag documentation indicates that it replaces "occurrances of strings", but the
code only replaces instances of the first character in the old string with the first character
in the new string.  It also does not accept an empty string as the new string.  I have a patch
that updates the replace tag to replace whole strings, as well as accept empty strings, available
here:
http://home.earthlink.net/~ofallon/patches/jelly-util-diff.txt
it updates both the code and the project.xml file to add a dependency on commons-lang.  All
of the existing util tag tests still passed after making this change.

If this change is implemented, it may also make sense to change the attributes "oldChar" and
"newChar" to just "old" and "new", but I'll leave decision that up to someone else :-)

Thanks,
Paul


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


Mime
View raw message