From scolebourne@apache.org  Sat Aug  2 11:20:48 2003
Return-Path: <scolebourne@apache.org>
Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm
Delivered-To: mailing list commons-dev@jakarta.apache.org
Received: (qmail 79423 invoked by uid 500); 2 Aug 2003 11:20:48 -0000
Received: (qmail 79411 invoked from network); 2 Aug 2003 11:20:48 -0000
Received: from unknown (HELO minotaur.apache.org) (209.237.227.194)
  by daedalus.apache.org with SMTP; 2 Aug 2003 11:20:48 -0000
Received: (qmail 13788 invoked by uid 1529); 2 Aug 2003 11:20:49 -0000
Date: 2 Aug 2003 11:20:49 -0000
Message-ID: <20030802112049.13787.qmail@minotaur.apache.org>
From: scolebourne@apache.org
To: jakarta-commons-cvs@apache.org
Subject: cvs commit: jakarta-commons/lang/src/java/org/apache/commons/lang CharRange.java
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

scolebourne    2003/08/02 04:20:49

  Modified:    lang/src/java/org/apache/commons/lang CharRange.java
  Log:
  Improve toString() using StringBuffer
  from Chris Feldhacker
  
  Revision  Changes    Path
  1.9       +11 -10    jakarta-commons/lang/src/java/org/apache/commons/lang/CharRange.java
  
  Index: CharRange.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/lang/src/java/org/apache/commons/lang/CharRange.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- CharRange.java	26 Jul 2003 15:33:34 -0000	1.8
  +++ CharRange.java	2 Aug 2003 11:20:49 -0000	1.9
  @@ -61,6 +61,7 @@
    *
    * @author <a href="bayard@generationjava.com">Henri Yandell</a>
    * @author Stephen Colebourne
  + * @author Chris Feldhacker
    * @since 1.0
    * @version $Id$
    */
  @@ -192,19 +193,19 @@
       /**
        * <p>Output a string representation of the character range.</p>
        * 
  -     * @return string representation
  +     * @return string representation of this range
        */
       public String toString() {
  -        String str = "";
  -        if( isNegated() ) {
  -            str += "^";
  +        StringBuffer buf = new StringBuffer(4);
  +        if (isNegated()) {
  +            buf.append('^');
           }
  -        str += start;
  -        if( isRange() ) {
  -            str += "-";
  -            str += close;
  +        buf.append(start);
  +        if (isRange()) {
  +            buf.append('-');
  +            buf.append(close);
           }
  -        return str;
  +        return buf.toString();
       }
       
   }