commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 22121] - [patch] The "required" validator doesn't work with String[] (multi-selects)
Date Tue, 05 Aug 2003 01:49:06 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22121>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22121

[patch] The "required" validator doesn't work with String[] (multi-selects)





------- Additional Comments From rleland@apache.org  2003-08-05 01:49 -------
This looks pretty good, though the code will be altered
a little since for regular fields a class cast exception would be thrown.
It should be possible to only try doing the cast when all else has failed.

Also then that would mean the client side Javascript is also
not handling String[] either, correct ?


Generally,
Normally you do a 'diff -u file.before.java file.after.java > file.diff'
or do it directly from CVS. If you are using windows you
can use the cygwin package to get all the unix type commands.
Then that patch added as an attachment.

Since this is a simple patch then 'inline' is ok.

For a more involved case you would create a simple test case that
shows the problem, that could then be used as a unit test.

Again, what you gave looks good.

Mime
View raw message