commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Feldhacker" <feldhacker.ch...@mchsi.com>
Subject Re: [lang] CharSet oversight?
Date Sat, 02 Aug 2003 20:29:50 GMT
Please consider the following patch.  Suggested changes included:

1) Made "serialVersionUID" private instead of default scope (same should be
done in CharSet)
2)  I question the need to cache the toString representation: is this really
necessary?  If so, then why not do it elsewhere?  I think that by caching
the toString value we could be preventing garbage collection of a cached
value that is no longer needed simply because our class continues to hang on
to it.  Besides, the toString method is extremely quick; perhaps if it was
more complex and intensive...  (even then, I would think the cached value
should be stored in a SoftReference to make sure garbage collection can
occur).

Thoughts?


----- Original Message ----- 
From: "Stephen Colebourne"
To: "Jakarta Commons Developers List"
Sent: Saturday, August 02, 2003 1:30 PM
Subject: Re: [lang] CharSet oversight?


> CharSet and CharRange now fully rewritten, javadocced and tested. Be great
> if you had a quick look....
>
> Stephen

Mime
View raw message