Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@apache.org Received: (qmail 36890 invoked from network); 20 Jul 2003 00:38:15 -0000 Received: from exchange.sun.com (192.18.33.10) by daedalus.apache.org with SMTP; 20 Jul 2003 00:38:15 -0000 Received: (qmail 3825 invoked by uid 97); 20 Jul 2003 00:40:54 -0000 Delivered-To: qmlist-jakarta-archive-commons-dev@nagoya.betaversion.org Received: (qmail 3818 invoked from network); 20 Jul 2003 00:40:53 -0000 Received: from daedalus.apache.org (HELO apache.org) (208.185.179.12) by nagoya.betaversion.org with SMTP; 20 Jul 2003 00:40:53 -0000 Received: (qmail 36657 invoked by uid 500); 20 Jul 2003 00:38:14 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 36642 invoked from network); 20 Jul 2003 00:38:13 -0000 Received: from umbongo.flamefew.net (64.253.103.114) by daedalus.apache.org with SMTP; 20 Jul 2003 00:38:13 -0000 Received: by umbongo.flamefew.net (Postfix on Linux (i386), from userid 500) id 3DEEC1B08; Sat, 19 Jul 2003 20:38:14 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by umbongo.flamefew.net (Postfix on Linux (i386)) with ESMTP id 304A51AD7 for ; Sat, 19 Jul 2003 20:38:14 -0400 (EDT) Date: Sat, 19 Jul 2003 20:38:14 -0400 (EDT) From: Henri Yandell X-X-Sender: hen@umbongo.flamefew.net To: Jakarta Commons Developers List Subject: Re: [lang] NumberUtils null handling In-Reply-To: <3F19D398.6040608@steitz.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Sat, 19 Jul 2003, Phil Steitz wrote: > I have been going through NumberUtils code and tests to make sure that > handling of nulls is documented (and tested) correctly. I notice that > createNumber returns null for null (need to add a javadoc comment for > this); whereas createFloat, et al will throw NPEs on null. Shouldn't > these behave the same? In any case, the behavior should be documented. > > Should I submit a patch to > > 1. Make createFloat et al return null for null as createNumber does +1 to the sub-package as Stephen said. > 2. Make no changes to NumberUtils methods, just add javadoc and tests > documenting current behavior. > > 3. Go back to sleep...;-) > > > Phil > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org > For additional commands, e-mail: commons-dev-help@jakarta.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org