commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject cvs commit: jakarta-commons/lang/src/java/org/apache/commons/lang/builder HashCodeBuilder.java
Date Fri, 25 Jul 2003 23:03:31 GMT
ggregory    2003/07/25 16:03:31

  Modified:    lang/src/java/org/apache/commons/lang/builder
                        HashCodeBuilder.java
  Log:
  Severity	Description	Resource	In Folder	Location	Creation Time
  	Unnecessary cast to type int for expression of type byte. It is already compatible with
the argument type int	HashCodeBuilder.java	Apache Jakarta Commons/lang/src/java/org/apache/commons/lang/builder
line 471	July 23, 2003 11:22:36 AM
  	Unnecessary cast to type int for expression of type char. It is already compatible with
the argument type int	HashCodeBuilder.java	Apache Jakarta Commons/lang/src/java/org/apache/commons/lang/builder
line 460	July 23, 2003 11:22:36 AM
  	Unnecessary cast to type int for expression of type short. It is already compatible with
the argument type int	HashCodeBuilder.java	Apache Jakarta Commons/lang/src/java/org/apache/commons/lang/builder
line 449	July 23, 2003 11:22:36 AM
  
  Revision  Changes    Path
  1.17      +4 -4      jakarta-commons/lang/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java
  
  Index: HashCodeBuilder.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/lang/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java,v
  retrieving revision 1.16
  retrieving revision 1.17
  diff -u -r1.16 -r1.17
  --- HashCodeBuilder.java	21 Jul 2003 23:30:42 -0000	1.16
  +++ HashCodeBuilder.java	25 Jul 2003 23:03:30 -0000	1.17
  @@ -446,7 +446,7 @@
        * @return this
        */
       public HashCodeBuilder append(short value) {
  -        iTotal = iTotal * iConstant + (int) value;
  +        iTotal = iTotal * iConstant + value;
           return this;
       }
   
  @@ -457,7 +457,7 @@
        * @return this
        */
       public HashCodeBuilder append(char value) {
  -        iTotal = iTotal * iConstant + (int) value;
  +        iTotal = iTotal * iConstant + value;
           return this;
       }
   
  @@ -468,7 +468,7 @@
        * @return this
        */
       public HashCodeBuilder append(byte value) {
  -        iTotal = iTotal * iConstant + (int) value;
  +        iTotal = iTotal * iConstant + value;
           return this;
       }
   
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message