commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Howard M. Lewis Ship" <hls...@comcast.net>
Subject RE: [lang] StringUtils isEmpty change
Date Fri, 18 Jul 2003 18:19:00 GMT
I would prefer to keep it the way it is.  If someone needs to explicitly check for null, let
them.
I missed the discussion about why this change is needed ... from my point of view, it looks
like
change for change's sake.

--
Howard M. Lewis Ship
Creator, Tapestry: Java Web Components
http://jakarta.apache.org/tapestry



> -----Original Message-----
> From: scolebourne@btopenworld.com 
> [mailto:scolebourne@btopenworld.com] 
> Sent: Friday, July 18, 2003 12:15 PM
> To: commons-dev@jakarta.apache.org
> Cc: hlship@comcast.net; hlship@comcast.net
> Subject: [lang] StringUtils isEmpty change
> 
> 
> Howard, Henning, Others,
> 
> Can you confirm or deny if the method isEmptyOrNull() is an 
> acceptably named replacement to isEmpty()? We are trying to 
> be more explicit in naming.
> 
> Otherwise can you find a word that means 'empty or null'? 
> Perhaps we could have isBlank() as a synonym of isEmptyOrNull?
> 
> Also, I should point out that the code you replaced in 
> turbine (see below) is not identical to that in 
> isEmpty()...which is part of the issue here.
> 
> I also now think that deprecation may be necessary here.
> 
> Stephen
> 
> 
> >  from:    "Henning P. Schmiedehausen" <hps@intermeta.de>
> > "Howard M. Lewis Ship" <hlship@comcast.net> writes:
> > 
> > >I must have missed this.  What change to StringUtils.isEmpty() are 
> > >you making.  I like it just the way it it ... I had an identical 
> > >method in Tapestry that I deprecated and pointed at 
> StringUtils. I'm 
> > >very much reliant on "" == null.
> > 
> > I strongly agree here! We replaced lots and lots of
> > 
> > if ((foo == null) || foo.equals(""))   with StringUtils.isEmpty()
> > 
> > if ((foo != null) && !foo.equals("")) with StringUtils.isNotEmpty()
> > 
> > in Turbine. If you change this behaviour, we would get 
> _very_ upset... 
> > :-)
> > 
> > 	Regards
> > 		Henning
> > 
> > -- 
> > Dipl.-Inf. (Univ.) Henning P. Schmiedehausen          INTERMETA GmbH
> > hps@intermeta.de         49 9131 50 654 0   http://www.intermeta.de/
> > 
> > Java, perl, Solaris, Linux, xSP Consulting, Web Services
> > freelance consultant -- Jakarta Turbine Development  -- 
> hero for hire
> > 
> > --- Quote of the week: "It is pointless to tell people 
> anything when 
> > you know that they won't process the message." --- Jonathan Revusky
> > 
> > 
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> > 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message