Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@apache.org Received: (qmail 60957 invoked from network); 20 Jun 2003 20:33:24 -0000 Received: from exchange.sun.com (192.18.33.10) by daedalus.apache.org with SMTP; 20 Jun 2003 20:33:24 -0000 Received: (qmail 20637 invoked by uid 97); 20 Jun 2003 20:35:48 -0000 Delivered-To: qmlist-jakarta-archive-commons-dev@nagoya.betaversion.org Received: (qmail 20630 invoked from network); 20 Jun 2003 20:35:48 -0000 Received: from daedalus.apache.org (HELO apache.org) (208.185.179.12) by nagoya.betaversion.org with SMTP; 20 Jun 2003 20:35:48 -0000 Received: (qmail 60697 invoked by uid 500); 20 Jun 2003 20:33:21 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 60678 invoked from network); 20 Jun 2003 20:33:21 -0000 Received: from exchange.sun.com (192.18.33.10) by daedalus.apache.org with SMTP; 20 Jun 2003 20:33:21 -0000 Received: (qmail 20623 invoked by uid 50); 20 Jun 2003 20:35:45 -0000 Date: 20 Jun 2003 20:35:45 -0000 Message-ID: <20030620203545.20622.qmail@nagoya.betaversion.org> From: bugzilla@apache.org To: commons-dev@jakarta.apache.org Cc: Subject: DO NOT REPLY [Bug 20964] - [math] Remove mode, remove some methods from StatUtils X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20964 [math] Remove mode, remove some methods from StatUtils ------- Additional Comments From phil@steitz.com 2003-06-20 20:35 ------- I want to keep StatUtils as lean as possible, partly because the methods are static. Regarding the build, all tests run fine for me after the change. Unfortunately, the test cases for UnivariateImpl do not execute the paths that would have caused failure. One more reason to get the path coverage up. Also, I neglected to execute maven clean before test. My mistake. I see now that these methods are reused, so we have to keep them in StatUtils (unless we decide to drop skewness and kurtosis from UnivariateImpl). I will submit a revised patch keeping these things in; but I am getting a little squemish about so many static methods. My preference would be to remove skewness and kurtosis from UnivariateImpl and StatUtils as well. I do not want to put the percentile computations into StatUtils. Yes, you are correct, the pre-1.2 sort implementation that I embedded in abstractStoreUnivariate.getSortedValues should be replaced by the ArrayUtils sort. I will submit a separate patch for this. --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org