commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robert burrell donkin <robertburrelldon...@blueyonder.co.uk>
Subject Re: Betwixt Question (Mixed Content) (Patch for reading mixed con tent)
Date Wed, 11 Jun 2003 21:30:57 GMT
hi Abraham

On Wednesday, June 11, 2003, at 08:45 PM, Fathman, Abraham wrote:

> Robert,
>
> Thanks for the quick response. I think that I have solved the easy use 
> case
> that you mentioned (It works for my situation anyway).
>
> I do have a few questions though:
>
> 1) In org.apache.commons.betwixt.XMLIntrospector line 330, should I add 
> the
> abilitiy to copy the ContentDescriptors?

i'm not sure i see this. it might be that some small stuff changed. it 
would very cool if you could get CVS set up and work from CVS HEAD. (if 
you need some instructors then i can supply some urls).

> 2) In org.apache.commons.betwixt.digester.TextRule line 135, should we be
> overriding the beanClass member variable with a local beanClass variable?

this looks very, very much like a coding mistake. i think that maybe the 
field at the top is a relic from a past incarnations. i've removed it in 
CVS HEAD.

> 3) In org.apache.commons.betwixt.io.BeanRuleSet line 347, is that the
> correct expression to make sure that we don't add duplicates? A better way
> to handle it, starting at line 248, might be to just handle the
> ElementDescriptors with the for loop and handle the non ElementDescriptors
> (TextDescriptors) in afterwards, line 351 for example.

(again, i'm a little unclear about the line numbers). are you talking 
about the getElementDescriptor method?

> I have included the patch (diff -r -u -d on the src directories between 
> the
> 060503-src.zip and what I changed) below.

(my first impressions) is that this looks fine. (but cvs diff -u against 
CVS HEAD would have been even better.)

could you supply some test cases? (we're big on test cases and usually 
they take me as long to write as the original code.) if you need some 
examples, look in the src/test directory structure.

- robert


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message