commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Barrett" <JBarr...@sawyermedia.com>
Subject RE: [VFS] exposing LocalFileName and it's associates
Date Fri, 13 Jun 2003 19:37:40 GMT
Hi,

I forgot to include one small change to GenericFileName to support the below email.  It's
a small change, probably done manually.  Even so, here's the diff:

Index: src/java/org/apache/commons/vfs/provider/GenericFileName.java
===================================================================
RCS file: /home/cvspublic/jakarta-commons-sandbox/vfs/src/java/org/apache/commons/vfs/provider/GenericFileName.java,v
retrieving revision 1.8
diff -u -r1.8 GenericFileName.java
--- src/java/org/apache/commons/vfs/provider/GenericFileName.java       17 Mar 2003 09:07:32
-0000   1.8
+++ src/java/org/apache/commons/vfs/provider/GenericFileName.java       13 Jun 2003 19:34:34
-0000
@@ -75,7 +75,7 @@
     private final String password;
     private final int port;

-    protected GenericFileName( final String scheme,
+    public GenericFileName( final String scheme,
                                final String hostName,
                                final int port,
                                final int defaultPort,

thanks,
+jeff

> -----Original Message-----
> From: Jeff Barrett 
> Sent: Monday, March 31, 2003 11:49 AM
> To: commons-dev@jakarta.apache.org
> Subject: [VFS] exposing LocalFileName and it's associates
> 
> 
> Howdy,
> 
> I've found it very useful to reuse some of the functionality 
> in various implementations of FileName outside of VFS.  To do 
> so with local files, I found it necessary to expose 
> LocalFileName and some of it's associates with a public 
> modifier.  It wasn't necessary for GenericFileName, it's 
> already public.  Is there any chance of this change making 
> into the VFS?  The changes are below for more info:
> 
> 
> 
> 
> Index: 
> src/java/org/apache/commons/vfs/provider/local/GenericFileName
> Parser.java
> ===================================================================
> RCS file: 
> /home/cvspublic/jakarta-commons-sandbox/vfs/src/java/org/apach
> e/commons/vfs/provider/local/GenericFileNameParser.java,v
> retrieving revision 1.5
> diff -u -r1.5 GenericFileNameParser.java
> --- 
> src/java/org/apache/commons/vfs/provider/local/GenericFileName
> Parser.java   12 Feb 2003 07:56:15 -0000      1.5
> +++ 
> src/java/org/apache/commons/vfs/provider/local/GenericFileName
> Parser.java   31 Mar 2003 19:44:52 -0000
> @@ -63,7 +63,7 @@
>   * @author <a href="mailto:adammurdoch@apache.org">Adam Murdoch</a>
>   * @version $Revision: 1.3 $ $Date: 2002/07/05 04:08:18 $
>   */
> -final class GenericFileNameParser
> +public final class GenericFileNameParser
>      extends LocalFileNameParser
>  {
>      /**
> Index: 
> src/java/org/apache/commons/vfs/provider/local/LocalFileName.java
> ===================================================================
> RCS file: 
> /home/cvspublic/jakarta-commons-sandbox/vfs/src/java/org/apach
> e/commons/vfs/provider/local/LocalFileName.java,v
> retrieving revision 1.5
> diff -u -r1.5 LocalFileName.java
> --- 
> src/java/org/apache/commons/vfs/provider/local/LocalFileName.j
> ava   17 Feb 2003 09:22:15 -0000   1.5
> +++ 
> src/java/org/apache/commons/vfs/provider/local/LocalFileName.j
> ava   31 Mar 2003 19:44:52 -0000
> @@ -66,14 +66,14 @@
>   * @author <a href="mailto:adammurdoch@apache.org">Adam Murdoch</a>
>   * @version $Revision: 1.5 $ $Date: 2003/02/17 09:22:15 $
>   */
> -class LocalFileName
> +public class LocalFileName
>      extends AbstractFileName
>  {
>      private final String rootFile;
> 
> -    private LocalFileName( final String scheme,
> -                           final String rootFile,
> -                           final String path )
> +    protected LocalFileName( final String scheme,
> +                             final String rootFile,
> +                             final String path )
>      {
>          super( scheme, path );
>          this.rootFile = rootFile;
> Index: 
> src/java/org/apache/commons/vfs/provider/local/LocalFileNamePa
> rser.java
> ===================================================================
> RCS file: 
> /home/cvspublic/jakarta-commons-sandbox/vfs/src/java/org/apach
> e/commons/vfs/provider/local/LocalFileNameParser.java,v
> retrieving revision 1.8
> diff -u -r1.8 LocalFileNameParser.java
> --- 
> src/java/org/apache/commons/vfs/provider/local/LocalFileNamePa
> rser.java     12 Feb 2003 07:56:15 -0000      1.8
> +++ 
> src/java/org/apache/commons/vfs/provider/local/LocalFileNamePa
> rser.java     31 Mar 2003 19:44:52 -0000
> @@ -64,7 +64,7 @@
>   * @author <a href="mailto:adammurdoch@apache.org">Adam Murdoch</a>
>   * @version $Revision: 1.5 $ $Date: 2002/03/09 10:31:30 $
>   */
> -abstract class LocalFileNameParser
> +public abstract class LocalFileNameParser
>  {
>      /**
>       * Determines if a name is an absolute file name.
> Index: 
> src/java/org/apache/commons/vfs/provider/local/WindowsFileName
> Parser.java
> ===================================================================
> RCS file: 
> /home/cvspublic/jakarta-commons-sandbox/vfs/src/java/org/apach
> e/commons/vfs/provider/local/WindowsFileNameParser.java,v
> retrieving revision 1.5
> diff -u -r1.5 WindowsFileNameParser.java
> --- 
> src/java/org/apache/commons/vfs/provider/local/WindowsFileName
> Parser.java   12 Feb 2003 07:56:15 -0000      1.5
> +++ 
> src/java/org/apache/commons/vfs/provider/local/WindowsFileName
> Parser.java   31 Mar 2003 19:44:52 -0000
> @@ -63,7 +63,7 @@
>   * @author <a href="mailto:adammurdoch@apache.org">Adam Murdoch</a>
>   * @version $Revision: 1.3 $ $Date: 2002/07/05 04:08:18 $
>   */
> -final class WindowsFileNameParser
> +public final class WindowsFileNameParser
>      extends LocalFileNameParser
>  {
>      /**
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message