commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 20496] - [math] Add sign() method to MathUtils
Date Thu, 05 Jun 2003 21:40:42 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20496>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20496

[math] Add sign() method to MathUtils





------- Additional Comments From mdiggory@latte.harvard.edu  2003-06-05 21:40 -------
I'll apply these and run the tests. But here are some comments.

1.) I suspect your using diff directly, I would recommend using cvs diff, this
way your diffs are built directly against the current cvs versions and not a
local copy (which I'm assuming is where the .java~2~ extensions are coming
from), this will also generate a header in your diff that looks similar to the
following

Index: MathUtilsTest.java
===================================================================
RCS file:
/home/cvs/jakarta-commons-sandbox/math/src/test/org/apache/commons/math/MathUtilsTest.java,v
retrieving revision 1.1
diff -u -r1.1 MathUtilsTest.java
--- MathUtilsTest.java  2003-06-03 13:39:19.000000000 -0700
+++ MathUtilsTest.java	2003-06-04 23:45:33.000000000 -0700

2.) Try to generate your patches from the root of the project (at the level of
the math directory), not at the individual file level. Then you do not need to
submit separate patches for each file.

This will help me to be able to quickly apply your patches.

Cheers and thank you for your excellent efforts,
Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message