commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Keyes <j...@mac.com>
Subject Re: [CLI][PATCH] Min and Max size for arguments
Date Wed, 11 Jun 2003 12:58:47 GMT
>> > ArgumentBuilder.withOptionalValues(boolean) has been removed since its
>> > a function of the min and max values.
>> >
>> > Argument.hasOptionalValues() has been retained and returns min<max
>> This should just return min == 0?  If min is > 0 then that means a
>> value is
>> required.
>
>Hmm, there's room for confusion here.  My implementation of hasOptionalValues() 
>says "are any values optional" whereas yours says "are all values optional".  
>I suspect that we should just drop the method and get people to ask the question 
>they mean to by using getMin/Max.
Good point.  The original impl was a boolean, all values are optional or
not.  When I am applying the patch later on I will incorporate this.

-John K


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message