commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maciek <mac...@pb-network.com>
Subject Re: [PATH]FileUpload fix for filename for msiexplorer
Date Sat, 28 Jun 2003 19:10:53 GMT
I did it on RedHat7.3 with the following command:
diff -u DefaultFileItem.java.orig DefaultFileItem.java >>
FileName_fix_forMSIE.txt
Regards,
maciej

On Sat, 2003-06-28 at 14:57, Tetsuya Kitahata wrote:
> 
> It seems that your [patch] (attachment file) has an extra carriage
> return CR added: 0D0D0A (CRCRLF: Two ASCII carriage returns and
> a line feed) instead of 0D0A (CRLF).
> 
> Needless to say, "diff -u" would make redundant patch because
> "diff" compares '0D0D0A' and '0D0A'.
> 
> How did you make this patch? (What kind of tool/editor did you use?)
> 
> Sincerely,
> 
> -- Tetsuya (tetsuya@apache.org)
> 
> P.S. I think recently "0D0D0A"s are scattered here and there
> in jakarta...
> 
> ---------------------------------------------------------------------
> 
> On 28 Jun 2003 13:46:31 -0400
> (Subject: [PATH]FileUpload fix for filename for msiexplorer)
> maciek <maciek@pb-network.com> wrote:
> 
> > Method getName() in DefaultFileItem.java class when used with
> > msiexplorer 5/6 returns a filename with the whole client's filesystem
> > path which creates a problem when you want to save the file on a
> > server's filesystem. I have chanaged the implementation of the getName()
> > method to strip the path information from the filename.Below is my
> > proposed implementation for getName() method:
> > 
> > public String getName()
> >     {
> >         
> >          if(fileName.lastIndexOf("\\") != -1){
> >                 
> >               return fileName.substring(fileName.lastIndexOf("\\") + 1);
> >              
> >          }else{
> > 
> >               return fileName;
> >          }
> >     } 
> > 
> > I have attached the fileName_fix_forMSIE.txt patch file.
> > 
> > I have rebuild the entire source code to create a new jar and tested it
> > with Tomcat and Resin. It works now with MSIE. A simple call to
> > item.getName() returns only filename where item is of type FileItem.
> > 
> > I think that it would be a better idea to change the implementation of
> > the method without breaking of the FileUpload component interface than
> > letting web developers to take care of the problem inside a jsp file.
> > I think users of the component should use the method transparently
> > without worrying about the possible problem with MSIE with the guarantee
> > that ONLY filename will be returned from getName() method.
> > Regards,
> > Maciej Brodala
> > 
> > 
> 
> -----------------------------------------------------
> Tetsuya Kitahata --  Terra-International, Inc.
> E-mail: kitahata@bb.mbn.or.jp : tetsuya@apache.org
> http://www.terra-intl.com/
> (Apache Jakarta Translation, Japanese)
> http://jakarta.terra-intl.com/
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message