Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Date: 2 May 2003 21:12:25 -0000
Message-ID: <20030502211225.18022.qmail@nagoya.betaversion.org>
From: bugzilla@apache.org
To: commons-dev@jakarta.apache.org
Cc: 
Subject: DO NOT REPLY [Bug 19615] New:  -
    Unecessary global synchronized in AbandonedObjectPool methods

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19615>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19615

Unecessary global synchronized in AbandonedObjectPool methods

           Summary: Unecessary global synchronized in AbandonedObjectPool
                    methods
           Product: Commons
           Version: 2.1 Final
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: Major
          Priority: Other
         Component: Dbcp
        AssignedTo: commons-dev@jakarta.apache.org
        ReportedBy: George.Lindholm@ubc.ca


Rather than having "public synchronized void returnObject()/borrowObject()"
wouldn't this be better if RemoveAbandoned is false:

    public void returnObject(Object obj) throws Exception {
      long startTime = System.currentTimeMillis();
        if (config != null && config.getRemoveAbandoned()) {
            synchronized(this) {
              trace.remove(obj);
            }
        }
        super.returnObject(obj);
    }

   George

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org