commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shapira, Yoav" <Yoav.Shap...@mpi.com>
Subject RE: [lang] StringEscapeUtils
Date Mon, 31 Mar 2003 14:08:21 GMT

Howdy,
A couple of comments, and a request: see intermixed.

>I've checked in my first pass at StringEscapeUtils.  It handles Java,
>JavaScript, and HTML entity escaping and unescaping.

Great -- thank you for contributing ;)

>* StringEscapeUtils is a bit much to type for a quick static API call
> -- should we rename it EscapeUtils?  It's not like there will be any
> other type of Escape...

I don't think it's a bit much, and I do like having the String in the
name of the class.  I can't think of any other EscapeUtils candidates,
but that doesn't mean there can't be any, so let's keep it as
StringEscapeUtils.

>* Java strings can handle raw single-quotes inside strings, but I

I agree.  Good thinking.

>* escapeJava now uses lowercase letters for hex codes.  Are there any
> feelings about switching to capital letters?  I prefer caps (like
> \uCAFE instead of \ucafe) but I could go either way.

No biggie either way.

>* I made use of (and thus contributed) my StringPrintWriter class.  Do
> you think it's useful enough to make it part of the public API (and
> add tests and docs for it)?

I would say keep it private unless/until there's demand to make it
public.  The more public stuff we have, the more we have to worry about
support and maintenance as we move forward.


>* XML escape, SQL escape. They're both easy, at least in the first
> pass.  But does anyone know how to escape high-bit and control
> chars in SQL?  (I know that JDBC has its own curly-brace escapes;
> that's out of scope for this function.)

XML escape and unescape was my request, so good to see you already had
that in mind ;)  It should be fairly simple to do with the regex stuff,
just have patterns for ",',&,<,>...

>* I think it'll be ready to roll for 2.0, but if we decide to
> postpone, I'll have to change the build.xml to exclude it from the
> jar.

A bit of a sticky point, the whole 2.0 release ;)  I think Mr. Yandell
already addressed this one ;)

Yoav Shapira
Millennium ChemInformatics



This e-mail, including any attachments, is a confidential business communication, and may
contain information that is confidential, proprietary and/or privileged.  This e-mail is intended
only for the individual(s) to whom it is addressed, and may not be saved, copied, printed,
disclosed or used by anyone else.  If you are not the(an) intended recipient, please immediately
delete this e-mail from your computer system and notify the sender.  Thank you.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message