commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robert burrell donkin <robertburrelldon...@blueyonder.co.uk>
Subject Re: [BeanUtils] Submitting a patch
Date Sun, 09 Mar 2003 19:57:42 GMT
hi

i'd say howard's advice seems about right. there is a page on the website 
that you might find useful:

http://jakarta.apache.org/commons/patches.html

i'll look forward to reviewing your patch.

- robert

On Sunday, March 9, 2003, at 04:04 PM, Howard M. Lewis Ship wrote:

> I just went through the same thing; I think your best bet is to create a
> BugZilla issue for the patch, give it a title of "[PATCH] JDBCDynaClass" 
> and
> add the patch as an attachment.  BugZilla will automatically send mail to
> the list, and someone with write access to CVS repository can pick it up 
> and
> apply the patch.
>
> --
> Howard M. Lewis Ship
> Creator, Tapestry: Java Web Components
> http://jakarta.apache.org/proposals/tapestry
>
>
>
>> -----Original Message-----
>> From: George Franciscus [mailto:george.franciscus@nexcel.ca]
>> Sent: Sunday, March 09, 2003 10:55 AM
>> To: commons-dev@jakarta.apache.org
>> Subject: [BeanUtils] Submitting a patch
>>
>>
>> I've made very good use of the BeanUtils package, so I've
>> decide to pay it back a little by contributing a small patch.
>> I saw a "FIX ME" in RowSetDynaClass suggesting to abstract
>> functionality to support this class and ResultSetDynaClass.
>>
>> This is my first patch, so I'm not entirely clear how to get
>> this "promoted". I've made modifications to both
>> RowSetDynaClass and ResultSetDynaClass and created an
>> abstract JDBCDynaClass to consolidate logic for the other
>> two. The new JDBCDynaClass has package visibility since I
>> can't see a purpose to use it out side of BeanUtils.
>>
>> I've run the build and all the tests regression very well. I
>> inspected the unit tests, but I don't have anything to add to
>> what already there. Since this is a simple refactor, nothing
>> new is required.
>>
>> Using WinCVS I have diff'ed it and I can see the changes made
>> to RowSetDynaClass and ResultSetDynaClass, but JDBCDynaClass
>> is identified as a non-cvs file and is not showing up in the
>> diff. What do I need to do to get the diff in order.
>>
>> Once I get the diff created properly, what do I need to do to
>> move this along?
>>
>> ~~George
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message