commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel F. Savarese" <...@savarese.org>
Subject Re: [PATCH] performance problem w/ FTPClient
Date Sat, 15 Mar 2003 21:05:30 GMT

In message <20030314194529.21011.qmail@web13907.mail.yahoo.com>, Patrick Schoon
veld writes:
>long to upload. The problem turned out to be in the
>__storeFileStream function where the class, by
>default, filters for line separator characters. 
...
>I added a function to optionally turn this feature
>off. I'm not sure if it's useful for anyone else, but
>it really helped me.

I don't think applying this patch makes sense.  If you don't need
ASCII mode line terminator translation, then you should just transfer the
file in binary mode.  The only point to transferring a file in ASCII
mode is if you need to transfer an ASCII file from platform 1 to platform
2 and have the platform 1 line terminators tanslated to platform 2
line terminators.  Otherwise, one just transfers the file as is in binary
mode.  Of course, I may be missing something so please correct me if
I'm wrong.

daniel



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message