commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 17963] New: - General cleanup in GenericObjectPool
Date Thu, 13 Mar 2003 17:21:59 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17963>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17963

General cleanup in GenericObjectPool

           Summary: General cleanup in GenericObjectPool
           Product: Commons
           Version: unspecified
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Pool
        AssignedTo: commons-dev@jakarta.apache.org
        ReportedBy: qmccombs@nequalsone.com


Here is a description of the changes in the attached patch file:

Fixes several javadocs updates for bad references linked objects and methods.

In borrowObject(), if _testOnBorrow is true and validation fails, the object 
is simply destroyed instead of being passivated first.

In the clear() method, the loop has been switched to a for loop allowing the 
Iterator object to be initialized in the scope of the loop.

In the evict() method, the code to remove an object from the pool has been 
consolidated into one place.  This fixes several problems:
1) In some places, the object was being passivated before it was being 
destroyed.
2) In some places, the call to _factory.detroyObject was not in a try catch 
block.

Also, in the evict() method, I removed some redundant type casts.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message