commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rwaldh...@apache.org
Subject cvs commit: jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/jdbc2pool Jdbc2PoolDataSource.java
Date Thu, 06 Mar 2003 18:13:38 GMT
rwaldhoff    2003/03/06 10:13:38

  Modified:    dbcp/src/java/org/apache/commons/dbcp/jdbc2pool
                        Jdbc2PoolDataSource.java
  Log:
  use booleanValue, not getBoolean, to parse a boolean from a string
  This closes bug 16629 <http://issues.apache.org/bugzilla/show_bug.cgi?id=16629>
  
  Revision  Changes    Path
  1.8       +7 -7      jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/jdbc2pool/Jdbc2PoolDataSource.java
  
  Index: Jdbc2PoolDataSource.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/jdbc2pool/Jdbc2PoolDataSource.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- Jdbc2PoolDataSource.java	16 Nov 2002 19:18:27 -0000	1.7
  +++ Jdbc2PoolDataSource.java	6 Mar 2003 18:13:37 -0000	1.8
  @@ -1540,7 +1540,7 @@
                   RefAddr ra = ref.get("isNew");
                   if (ra != null && ra.getContent() != null) 
                   {
  -                    isNew = Boolean.getBoolean(ra.getContent().toString());
  +                    isNew = Boolean.valueOf(ra.getContent().toString()).booleanValue();
                   }
   
                   ra = ref.get("instanceKey");
  @@ -1559,7 +1559,7 @@
                   if (ra != null && ra.getContent() != null) 
                   {
                       setDefaultAutoCommit
  -                        (Boolean.getBoolean(ra.getContent().toString()));
  +                        (Boolean.valueOf(ra.getContent().toString()).booleanValue());
                   }
   
                   ra = ref.get("defaultMaxActive");
  @@ -1587,7 +1587,7 @@
                   if (ra != null && ra.getContent() != null) 
                   {
                       setDefaultReadOnly
  -                        (Boolean.getBoolean(ra.getContent().toString()));
  +                        (Boolean.valueOf(ra.getContent().toString()).booleanValue());
                   }
   
                   ra = ref.get("description");
  @@ -1655,14 +1655,14 @@
                   if (ra != null && ra.getContent() != null) 
                   {
                       setTestOnBorrow
  -                        (Boolean.getBoolean(ra.getContent().toString()));
  +                        (Boolean.valueOf(ra.getContent().toString()).booleanValue());
                   }
   
                   ra = ref.get("testOnReturn");
                   if (ra != null && ra.getContent() != null) 
                   {
                       setTestOnReturn
  -                        (Boolean.getBoolean(ra.getContent().toString()));
  +                        (Boolean.valueOf(ra.getContent().toString()).booleanValue());
                   }
   
                   ra = ref.get("timeBetweenEvictionRunsMillis");
  @@ -1690,7 +1690,7 @@
                   if (ra != null && ra.getContent() != null) 
                   {
                       setTestWhileIdle
  -                        (Boolean.getBoolean(ra.getContent().toString()));
  +                        (Boolean.valueOf(ra.getContent().toString()).booleanValue());
                   }
                   
                   ra = ref.get("validationQuery");
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message