commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Colebourne" <scolebou...@btopenworld.com>
Subject Re: [collections] [PATCH] typed Collection, List, Set, Bag, and Map
Date Wed, 12 Mar 2003 00:06:19 GMT
It'll be at least the weekend before I get to it. So there's time for other
support/objections.
Stephen

----- Original Message -----
From: "Rodney Waldhoff" <rwaldhoff@apache.org>
To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Sent: Wednesday, March 12, 2003 12:00 AM
Subject: Re: [collections] [PATCH] typed Collection, List, Set, Bag, and Map


> On Tue, 11 Mar 2003, Stephen Colebourne wrote:
>
> > The type-limited collection concept is probably the most common of the
> > predicate implementations. It was also the one from which predicated
> > collections were born. Although this patch will not really add any new
> > functionality to [collections], it will significantly aid code
readability
> > in a common case. That is enough for me, although I should make it clear
> > that I would not support every addition of this kind.
> >
> > I would like to commit this, are you casting a vote?
>
> No worse than -0.  I agree it's the most common case, personally I find
> the predicatedBag form more readable.
>
> > Stephen
> >
> > ----- Original Message -----
> > From: "Rodney Waldhoff" <rwaldhoff@apache.org>
> > > Can someone clarify the advantage of:
> > >
> > >  typedBag(bag, String.class)
> > >
> > > over
> > >
> > >  predicatedBag(bag, new InstanceofPredicate(String.class));
> > >
> > > ?
> > >
> > > On Mon, 11 Mar 2003, grumpoxl wrote:
> > >
> > > > The patches will take more than one message due to the size limit.
> > > >
> > > > I added typedXXX(Collection, Class) and typedXXX(Class) methods in
each
> > > > of the Utils classes.
> > > >
> > > > I added some test cases for typedXXX, which were pretty close copies
of
> > > > the tests for predicatedXXX.  I didn't see any tests for BagUtils.
> > > >
> > > > I may have accidentally hit the "format" command in Eclipse while
> > > > editing MapUtils and TestCollectionUtils, that is why the patch
files
> > > > are so large.  If necessary, I can redo those changes on a fresh
> > > > version.
> > > >
> > > > A desire for predicatedXXX(Predicate) methods in the Utils classes
was
> > > > mentioned before.  If all of these changes can be committed... I can
> > > > submit patches for those soon after.
> > > >
> > > > Thanks, let me know if there are any problems.
> > > >
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message