Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@apache.org Received: (qmail 48089 invoked from network); 3 Feb 2003 21:44:01 -0000 Received: from exchange.sun.com (192.18.33.10) by daedalus.apache.org with SMTP; 3 Feb 2003 21:44:01 -0000 Received: (qmail 6712 invoked by uid 97); 3 Feb 2003 21:45:33 -0000 Delivered-To: qmlist-jakarta-archive-commons-dev@nagoya.betaversion.org Received: (qmail 6705 invoked from network); 3 Feb 2003 21:45:32 -0000 Received: from daedalus.apache.org (HELO apache.org) (208.185.179.12) by nagoya.betaversion.org with SMTP; 3 Feb 2003 21:45:32 -0000 Received: (qmail 47836 invoked by uid 500); 3 Feb 2003 21:43:58 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 47824 invoked by uid 500); 3 Feb 2003 21:43:57 -0000 Received: (qmail 47821 invoked from network); 3 Feb 2003 21:43:57 -0000 Received: from icarus.apache.org (208.185.179.13) by daedalus.apache.org with SMTP; 3 Feb 2003 21:43:57 -0000 Received: (qmail 56237 invoked by uid 1052); 3 Feb 2003 21:43:57 -0000 Date: 3 Feb 2003 21:43:57 -0000 Message-ID: <20030203214357.56236.qmail@icarus.apache.org> From: costin@apache.org To: jakarta-commons-cvs@apache.org Subject: cvs commit: jakarta-commons/modeler/src/java/org/apache/commons/modeler/modules MbeansDescriptorsIntrospectionSource.java X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N costin 2003/02/03 13:43:57 Modified: modeler/src/java/org/apache/commons/modeler/modules MbeansDescriptorsIntrospectionSource.java Log: Set the readable/writtable flag. Support isXXX methods. Revision Changes Path 1.5 +29 -2 jakarta-commons/modeler/src/java/org/apache/commons/modeler/modules/MbeansDescriptorsIntrospectionSource.java Index: MbeansDescriptorsIntrospectionSource.java =================================================================== RCS file: /home/cvs/jakarta-commons/modeler/src/java/org/apache/commons/modeler/modules/MbeansDescriptorsIntrospectionSource.java,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- MbeansDescriptorsIntrospectionSource.java 24 Jan 2003 22:38:44 -0000 1.4 +++ MbeansDescriptorsIntrospectionSource.java 3 Feb 2003 21:43:57 -0000 1.5 @@ -123,7 +123,7 @@ Class ret=methods[j].getReturnType(); if( ! supportedType( ret ) ) { if( log.isDebugEnabled() ) - log.debug("Unsupported type " + methods[j] + " " + ret ); + log.debug("Unsupported type " + methods[j]); continue; } name=unCapitalize( name.substring(3)); @@ -133,6 +133,28 @@ attMap.put( name, methods[j] ); } else if( name.startsWith( "is" ) ) { // not used in our code. Add later + Class params[]=methods[j].getParameterTypes(); + if( params.length != 0 ) { + if( log.isDebugEnabled()) + log.debug("Wrong param count " + name + " " + params.length); + continue; + } + if( ! Modifier.isPublic( methods[j].getModifiers() ) ) { + if( log.isDebugEnabled()) + log.debug("Not public " + methods[j] ); + continue; + } + Class ret=methods[j].getReturnType(); + if( Boolean.TYPE != ret ) { + if( log.isDebugEnabled() ) + log.debug("Unsupported type " + methods[j] + " " + ret ); + continue; + } + name=unCapitalize( name.substring(2)); + + getAttMap.put( name, methods[j] ); + // just a marker, we don't use the value + attMap.put( name, methods[j] ); } else if( name.startsWith( "set" ) ) { Class params[]=methods[j].getParameterTypes(); @@ -222,7 +244,12 @@ ai.setDescription("Introspected attribute " + name); if( log.isDebugEnabled()) log.debug("Introspected attribute " + name + " " + gm + " " + sm); - mbean.addAttribute(ai); + if( gm==null ) + ai.setReadable(false); + if( sm==null ) + ai.setWriteable(false); + if( sm!=null || gm!=null ) + mbean.addAttribute(ai); } en=invokeAttMap.keys(); --------------------------------------------------------------------- To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-dev-help@jakarta.apache.org