commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 16525] - BeanUtils.setProperty is over-zealous at converting types
Date Mon, 03 Feb 2003 23:52:58 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16525>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16525

BeanUtils.setProperty is over-zealous at converting types





------- Additional Comments From tpv@spamcop.net  2003-02-03 23:52 -------
W.R.T. the first patch I agree. It was more a case of "The current behaviour
breaks a previously existing usage, this change would allow that behaviour
back". I don't think it should be applied it just helped to illustrate why the
curren behaviour doesn't work.

The 2nd patch is my proposal, but as you say, it is quite large. I wouldn't rush
out a release that uses it, I'd probably hold it for a 1.6.5 or 1.7 (as oppposed
to a 1.6.1 that contains Craig's DyanBean change). My guess is that Struts is
the biggest user of setProperty() so if this change works with struts, then it's
probably safe.

W.R.T the new class, it's package scoped, so I think your fears are alleviated
by that - I could have made it an inner class or  included it another
compilation unit, but that tends not to be a style I opt for.
I'm happy if you want to change it, but I'm not sure there's a problem (unless
I'm missing something)

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message