commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tobr...@transolutions.net (O'brien, Tim)
Subject RE: [codec] RE: Base64.java
Date Fri, 07 Feb 2003 00:13:42 GMT

Alright, changes were made to org.apache.commons.codec.binary.Base64

#1 byte[] Base64.encode( byte[] ) 	- No chunking, for HttpClient
#2 byte[] Base64.encodeChunked( byte[] )   - chunking for RFC 2045
compliance
#3 byte[] Base64.encode( byte[], boolean )  - there was no reason to make
this method private

We can make #3 private is someone feels strongly about it, but for now.
We've got a solution for reuse across two projects.

Next step: We need a better way to supply test data and expected encodings
to these Junit tests - anyone have any experience with something like
JXUnit?


--------
Tim O'Brien 

> -----Original Message-----
> From: Jeffrey Dever [mailto:jsdever@sympatico.ca] 
> Sent: Tuesday, February 04, 2003 3:11 PM
> To: Jakarta Commons Developers List
> Subject: Re: [codec] RE: Base64.java
> 
> 
> Well said.  Totally agree.
> 
> Ryan Hoegg wrote:
> 
> > We do as well.  Codec should probably end up with the 
> union, not the 
> > intersection   However, ours tests for the MIME specific 76 
> character 
> > line wrapping.
> >
> > --
> > Ryan Hoegg
> > ISIS Networks
> > http://www.isisnetworks.net
> >
> > Jeffrey Dever wrote:
> >
> >> That sounds good here too.  We only call Base64 methods a couple of
> >> times anyway, so adaptation is a minor issue.
> >>
> >> Just a note about tests, we have a Junit test class (not sure if
> >> xml-rpc has one) that should go along with the main Base64 class.  
> >> You did a grep on the code base so I'm sure you are aware of it.
> >>
> >> Jandalf.
> >>
> >>> I like your plan Tim.  Let's get 1.1 nailed down so we are all on
> >>> the same codebase, and do the design of 2.0 right.  I don't think 
> >>> XML-RPC cares much whether we get the default in 
> decode(byte[]) in 
> >>> 1.1, I think that decision should be made based on RFC 
> interpretation.
> >>>
> >>> --
> >>> Ryan Hoegg
> >>> ISIS Networks
> >>> http://www.isisnetworks.net 
> >>
> >>
> >
> >
> > 
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >
> >
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Mime
View raw message