Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@apache.org Received: (qmail 91975 invoked from network); 27 Jan 2003 16:33:31 -0000 Received: from exchange.sun.com (192.18.33.10) by daedalus.apache.org with SMTP; 27 Jan 2003 16:33:31 -0000 Received: (qmail 19265 invoked by uid 97); 27 Jan 2003 16:34:51 -0000 Delivered-To: qmlist-jakarta-archive-commons-dev@jakarta.apache.org Received: (qmail 19176 invoked by uid 97); 27 Jan 2003 16:34:48 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 19089 invoked by uid 98); 27 Jan 2003 16:34:45 -0000 X-Antivirus: nagoya (v4218 created Aug 14 2002) Message-ID: <3E355E64.2020505@GargoyleSoftware.com> Date: Mon, 27 Jan 2003 11:29:24 -0500 From: Mike Bowler Organization: Gargoyle Software User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2.1) Gecko/20021130 X-Accept-Language: en-us, en MIME-Version: 1.0 To: commons-dev@jakarta.apache.org Subject: Proposed style change Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Authentication-Info: Submitted using SMTP AUTH PLAIN at fep03-mail.bloor.is.net.cable.rogers.com from [24.103.205.29] using ID at Mon, 27 Jan 2003 11:33:00 -0500 X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N I am going through the code and changing it to conform to the style as per checkstyle. There are two places that I think we may want to be a little more lenient than the defaults and so I'm putting them here for discussion. 1) Line length of 80 The number 80 originally came from the days when printers could only print 80 columns. These days, that number doesn't make nearly as much sense. While I think we still want to have a maximum length, I believe that 80 is too short. In most of the places that we are exceeding the limit, we are just over by a bit (between 80 and 90). I propose that we change the max length to 100. This is still short enough that nobody should have to scroll to see the source but long enough that we aren't artificially breaking lines. 2) Instance variable names Some of the code uses leading underscores for variable names but this isn't allowed by checkstyle. The pattern it checks for is ^[a-z][a-zA-Z0-9]*$ I find significant benefit to being able to quickly distinguish instance variables from local variables and the leading underscore lets me do that easily. (I personally prefer trailing underscores to leading ones but I can live with either) I propose that we change the pattern for instance variables to ^_?[a-z][a-zA-Z0-9]*$ so that we will allow leading underscores but will not insist on it. Comments? -- Mike Bowler Principal, Gargoyle Software Inc. Voice: (416) 822-0973 | Email : mbowler@GargoyleSoftware.com Fax : (416) 822-0975 | Website: http://www.GargoyleSoftware.com -- To unsubscribe, e-mail: For additional commands, e-mail: