Return-Path: 
 <commons-dev-return-22718-qmlist-jakarta-archive-commons-dev=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-commons-dev-archive@apache.org
Received: (qmail 14395 invoked from network); 14 Jan 2003 23:24:32 -0000
Received: from exchange.sun.com (192.18.33.10)
  by daedalus.apache.org with SMTP; 14 Jan 2003 23:24:32 -0000
Received: (qmail 12993 invoked by uid 97); 14 Jan 2003 23:25:55 -0000
Delivered-To: qmlist-jakarta-archive-commons-dev@jakarta.apache.org
Received: (qmail 12925 invoked by uid 97); 14 Jan 2003 23:25:54 -0000
Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:commons-dev-unsubscribe@jakarta.apache.org>
List-Subscribe: <mailto:commons-dev-subscribe@jakarta.apache.org>
List-Help: <mailto:commons-dev-help@jakarta.apache.org>
List-Post: <mailto:commons-dev@jakarta.apache.org>
List-Id: "Jakarta Commons Developers List" <commons-dev.jakarta.apache.org>
Reply-To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Delivered-To: mailing list commons-dev@jakarta.apache.org
Received: (qmail 12902 invoked by uid 98); 14 Jan 2003 23:25:52 -0000
X-Antivirus: nagoya (v4218 created Aug 14 2002)
Message-ID: <20030114232430.85295.qmail@web12402.mail.yahoo.com>
Date: Tue, 14 Jan 2003 15:24:30 -0800 (PST)
From: Morgan Delagrange <mdelagra@yahoo.com>
Reply-To: morgand@apache.org
Subject: Re: [Jelly] using bean, junit, etc. tags in core unit tests
To: Jakarta Commons Developers List <commons-dev@jakarta.apache.org>
In-Reply-To: 
 <OF45876F58.2014D3DF-ONCA256CAE.007AE3A2-CA256CAE.007E7A36@multitask.com.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N


--- dion@multitask.com.au wrote:
> I'm not so sure I like the idea of using jars for
> testing without 
> declaring them as a dependency.

I don't think of it as a dependency, it's essentially
just declaring multiple source trees for the test
classes, and some of those test classes happen to have
a Jelly tag interface.  It's not an elegant approach,
but it does allow bean, junit, log, etc. tags to be
released independently of the core, which I think is a
good goal.

Theoretically, do you think that an approach like this
can be reflected in the generated Ant script?  Even if
not, it may be worth an extra manual step to creating
Ant scripts if no better way presents itself.

> I'd be happier if we could change the tests to not
> rely on them.

I'd be fine with that if it didn't affect the
effectiveness of the tests.  If we end up with equally
good, non-convoluted tests, +1.

> I'm currently working on removing the bean code from
> the core tests. It's 
> tedious and error prone, but worthwhile AFAIK.

I was wondering what was going on there.  :)

Cool.  Even if we did end up including tags like junit
in the unit tests, I'd prefer core to be completely
decoupled from bean.

> If the core couldn't use the test and log taglibs I
> wouldn't be averse to 
> rewriting the existing tests to stop using them.

It's inconvenient, but I think it's important that
junit tags have a separate release cycle.  We can
achieve this by including the junit tag classes with
the test classes or by removing the junit tags in the
core unit tests.  I'm fine with either, whatever works
out the best for us.  There may be better approaches
too; I'm open to suggestions.

- Morgan

> --
> dIon Gillard, Multitask Consulting
> Blog:     
> http://www.freeroller.net/page/dion/Weblog
> Work:      http://www.multitask.com.au
> 
> 
> Morgan Delagrange <mdelagra@yahoo.com> wrote on
> 15/01/2003 08:19:12 AM:
> 
> > Hey all,
> > 
> > So I can't see an obvious way to do it in
> project.xml,
> > but I can write a preGoal in maven.xml that will
> allow
> > the core build to use non-core tags for unit
> tests. 
> > E.g. this is what you would need to do if we
> removed
> > the "bean" classes from the core:
> > 
> >   <preGoal name="test:compile">
> > 
> >     <mkdir dir="target/test-source"/>
> > 
> >     <copy todir="target/test-source">
> >       <!-- core unit test classes -->
> >       <fileset dir="src/test"/>
> > 
> >       <!-- 
>         core unit tests rely on both the bean
>  
> > taglib and classes in the bean taglib's
>         unit tests
>       -->
> >       <fileset dir="jelly-tags/bean/src/test">
> >           <exclude name="**/Test*.java"/>
> >       </fileset>
> >       <fileset dir="jelly-tags/bean/src/java"/>
> >     </copy>
> > 
> >   </preGoal>
> > 
> > And then, of course, the "unitTestSourceDirectory"
> in
> > project.xml becomes "target/test-source".  Works
> > great, but unfortunately it doesn't allow for
> > automatic generation of the ant script.  Does
> anyone
> > know of a way to create a similar result while
> > preserving ant script generation?
> > 
> > - Morgan
> > 
> > =====
> > Morgan Delagrange
> > http://jakarta.apache.org/taglibs
> > http://jakarta.apache.org/commons
> > http://axion.tigris.org
> > http://jakarta.apache.org/watchdog
> > 
> > __________________________________________________
> > Do you Yahoo!?
> > Yahoo! Mail Plus - Powerful. Affordable. Sign up
> now.
> > http://mailplus.yahoo.com
> > 
> > --
> > To unsubscribe, e-mail: 
> <mailto:commons-dev-unsubscribe@jakarta.apache.org>
> > For additional commands, e-mail: 
> <mailto:commons-dev-help@jakarta.apache.org>
> > 
> 
> > ForwardSourceID:NT000A2D6E 
> 
> --
> To unsubscribe, e-mail:  
> <mailto:commons-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail:
> <mailto:commons-dev-help@jakarta.apache.org>
> 


=====
Morgan Delagrange
http://jakarta.apache.org/taglibs
http://jakarta.apache.org/commons
http://axion.tigris.org
http://jakarta.apache.org/watchdog

__________________________________________________
Do you Yahoo!?
Yahoo! Mail Plus - Powerful. Affordable. Sign up now.
http://mailplus.yahoo.com

--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>