commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d...@multitask.com.au
Subject Re: cvs commit: jakarta-commons-sandbox/jelly/jelly-tags/http maven.xml project.properties project.xml
Date Fri, 03 Jan 2003 00:44:54 GMT
A few comments for discussion:

morgand@apache.org wrote on 03/01/2003 11:26:42 AM:
[snip]

>   Index: maven.xml
>   ===================================================================
>   <project default="java:jar" xmlns:j="jelly:core" xmlns:
> maven="jelly:maven" xmlns:util="jelly:util">
> 
>     <!-- copies unit testing stuff -->
>     <postGoal name="test:compile">
This should no longer be necessary with the unitTest/resources/resource 
stuff.

>       <copy todir="${maven.test.dest}">
>         <fileset dir="src/test">
>           <include name="**/*.properties"/>
>           <include name="META-INF/services/*"/>
>           <include name="**/*.jelly"/>
>           <include name="**/*.xml"/>
>           <include name="**/*.html"/>
>           <include name="**/*.dtd"/>
>           <include name="**/*.rng"/>
>         </fileset>
>       </copy>
>     </postGoal>
> 
>   </project>
> 
> 
[snip]
>   Index: project.properties
[snip]
>   maven.jarResources.basedir=src/java
This property wont be used anymore.

[snip]
>   # use Sun coding standards
Maven now defaults to Sun coding standards. But since we're overriding, we 
should use:

maven.checkstyle.properties=project.properties

>   maven.checkstyle.header.ignore.line = 1,2,3,4,5,6
This becomes
checkstyle.header.ignoreline = 1,2,3,4,5,6

>   maven.checkstyle.const.pattern = ^[a-z][a-zA-Z0-9]*$
checkstyle.pattern.const = ^[a-z][a-zA-Z0-9]*$
> 
[snip]
>   maven.checkstyle.max.line.len = 100
checkstyle.maxlinelen = 100

>   maven.checkstyle.ignore.whitespace = true
checkstyle.ignore.whitespace = true

>   maven.checkstyle.ignore.public.in.interface = true
checkstyle.ignore.public.in.interface = true

[snip]
>   Index: project.xml
>   ===================================================================
>   <?xml version="1.0" encoding="UTF-8"?>
>   <!DOCTYPE project [
>     <!-- see file for description -->
>     <!ENTITY commonDeps SYSTEM "file:../../commonDependencies.ent">
>   ]>
We could use the <extend> of the project to pick up common elements.

[snip]

>       <dependency>
>         <id>commons-jelly</id>
>         <version>SNAPSHOT</version>
>       </dependency>
Jelly's got to be in the common dependencies, right?

I was going to do this as a commit, but I figured we should discuss it 
first.

Fire away, I've got the flameproof suit on :)
--
dIon Gillard, Multitask Consulting
Blog:      http://www.freeroller.net/page/dion/Weblog
Work:      http://www.multitask.com.au



--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>


Mime
View raw message