Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@apache.org Received: (qmail 90272 invoked from network); 12 Dec 2002 21:42:00 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 12 Dec 2002 21:42:00 -0000 Received: (qmail 3490 invoked by uid 97); 12 Dec 2002 21:43:02 -0000 Delivered-To: qmlist-jakarta-archive-commons-dev@jakarta.apache.org Received: (qmail 3380 invoked by uid 97); 12 Dec 2002 21:42:57 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 3331 invoked by uid 98); 12 Dec 2002 21:42:56 -0000 X-Antivirus: nagoya (v4218 created Aug 14 2002) To: commons-dev@jakarta.apache.org X-Injected-Via-Gmane: http://gmane.org/ Path: not-for-mail From: Costin Manolache Subject: Re: [logging] Adding jndi java:env support Date: Thu, 12 Dec 2002 13:29:51 -0800 Lines: 112 Message-ID: References: <94708C12-0E00-11D7-B2A8-003065DC754C@blueyonder.co.uk> NNTP-Posting-Host: 64.84.39.162 Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit X-Trace: main.gmane.org 1039729178 9147 64.84.39.162 (12 Dec 2002 21:39:38 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Thu, 12 Dec 2002 21:39:38 +0000 (UTC) User-Agent: KNode/0.7.1 Sender: news X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N The big issue is the behavior. My proposal was: if java:env/comp/LoggingDomain is set ( as a String ), it'll be used as a prefix in all loggers ( that don't have a prefix ). The syntax for the logger names will become: DOMAIN:LOGGER And all loggers will have to be configured with this name ( if running in a container env with LoggingDomain support ). This is very important - and I would like to see more opinions. Maybe we should use the domain as a suffix instead of prefix ? Then you would have: org.apache.foo:host:8080/examples as the log name, but you can set org.apache.foo.* to debug and enable the loggers in all apps. The prefix is cleaner, but the suffix may be easier to configure. For implementation - I'm in no hurry ( I would like to have it before tomcat5 is released - but that's not very close ). And I can use reflecion or a hook, if needed. Costin Richard Sitze wrote: > I'll wait for the formal call to vote before I start voting, BUT I support > the following: > > + release a 1.0.3 before any major code changes > + JNDI > > - NO API changes > - NO new runtime dependencies, and I'd like to be able to build, even if > I cannot test it. > > > > ******************************************* > Richard A. Sitze > > > > > sounds like a good plan. > > this sounds (to me) like a change big enough to call for a new (major?) > version. > > (i'm not a cvs expert) but from what i can see there have been some small > changes since the last release. maybe a quick bugfix 1.0.3 release would > be a good idea before adding making this change. > > - robert > > On Thursday, December 12, 2002, at 03:29 AM, Costin Manolache wrote: > >> Based on Ceki's email - I think it would be a good idea to add >> this mechanism in the default logging factory. >> >> My proposal is to insert a lookup for >> >> java:comp/env/CommonsLoggingFactory >> >> at the top of the discovery chain. If such a factory exists, it'll >> be used to create the logger. If not, we'll continue with the >> normal mechanism. >> >> The big downsize is that we'll add a compile dependency on >> JNDI ( the code can catch ClassNotFound - and run even if >> JNDI is not present ). >> >> This will allow containers using commons-logging to better enforce >> isolation between apps. >> >> In addition, I think we should add an optional "domain name" prefix. >> If such a prefix is set ( for example in >> java:comp/env/CommonsLoggingDomain) >> then it'll be added in front of every log name that is created. >> >> For example, if the container will set myHost:8080/myApp/ as a prefix, >> logs created in that app will be named: >> myHost:8080/myApp/org.apache..... >> >> >> As a note, web.xml allows you to define and set a number of >> jndi entries. This could also be used to allow user-based tuning, >> but in general the container settings should be able to >> take preference . >> >> Costin >> >> >> >> >> -- >> To unsubscribe, e-mail: . >> org> >> For additional commands, e-mail: . >> org> >> > > > -- > To unsubscribe, e-mail: < > mailto:commons-dev-unsubscribe@jakarta.apache.org> > For additional commands, e-mail: < > mailto:commons-dev-help@jakarta.apache.org> -- To unsubscribe, e-mail: For additional commands, e-mail: