Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@apache.org Received: (qmail 88936 invoked from network); 10 Dec 2002 14:33:41 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 10 Dec 2002 14:33:41 -0000 Received: (qmail 2923 invoked by uid 97); 10 Dec 2002 14:34:21 -0000 Delivered-To: qmlist-jakarta-archive-commons-dev@jakarta.apache.org Received: (qmail 2879 invoked by uid 97); 10 Dec 2002 14:34:19 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 2860 invoked by uid 98); 10 Dec 2002 14:34:19 -0000 X-Antivirus: nagoya (v4218 created Aug 14 2002) content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: DBCP tracking stale connections? X-MimeOLE: Produced By Microsoft Exchange V6.0.5762.3 Date: Tue, 10 Dec 2002 15:30:30 +0100 Message-ID: <61BAD406AA642745AE1142AF689E8D8E030A6B@madocontrol.madocke.local> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: DBCP tracking stale connections? Thread-Index: AcKgUjiqrZnDAzZtTYC7z6+lQEKlZwABZ3nA From: "Martin van Dijken" To: "Jakarta Commons Developers List" X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N > > > BasicDataSource currently doesn't expose testWhileIdle, > > > although if you look at how the other props are dealt with, > > > it wouldn't be difficult to expose it (a small change to > > > BasicDataSourceFactory and BasicDataSource is all that is > > > required). I'd be happy to commit the patch if you test > > > it first. Ok, in what form can I expect the patch? > Unless all your queries are a simple as "select 1" the=20 > performance boost > will be substantially less than 100%, but testOnBorrow is a fairly > expensive option (but guarentees that the connection is valid when you > obtain it). True enough, but our queries are mostly "select from tblX where Y" = without joins, groupings or whatever. There will be a substantial = performance gain. > Great. I even wasn't thinking anything that elaborate. I=20 > just wanted you to test that the property is making its way=20 > from your XML configuration to the instantiated pool (so I=20 > don't have to install and configure a new tomcat instance=20 > to test the patch). Sure I've got a few machines running with Tomcat and JNDI configured on = it. Question tho: Can you put a debug statement or something in = testOnBorrow and testOnIdle? That way I don't need to hack into the code = myself:) Saves me some reverse engineering:). > GenericObjectPool supports an "evictor thread" that does this sort of > thing. =20 Thanks for the info on GOP eviction. > BasicDataSource is convienient within Tomcat. Sure is, I'll stick to it until otherwise is proven. > The JavaDocs are probably the most complete documentation=20 > (and include more than simple method descriptions) Yeah I saw them. They are fairly complete, but I'm the kind of jerk who = really wants a step by step Dummy manual:). Greetz, Martin van Dijken -- To unsubscribe, e-mail: For additional commands, e-mail: