Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@apache.org Received: (qmail 12402 invoked from network); 16 Dec 2002 16:26:25 -0000 Received: from exchange.sun.com (HELO nagoya.betaversion.org) (192.18.33.10) by daedalus.apache.org with SMTP; 16 Dec 2002 16:26:25 -0000 Received: (qmail 29152 invoked by uid 97); 16 Dec 2002 16:27:32 -0000 Delivered-To: qmlist-jakarta-archive-commons-dev@jakarta.apache.org Received: (qmail 29136 invoked by uid 97); 16 Dec 2002 16:27:32 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 29124 invoked by uid 98); 16 Dec 2002 16:27:31 -0000 X-Antivirus: nagoya (v4218 created Aug 14 2002) Message-ID: <06dd01c2a51f$dbce8830$9865fea9@spiritsoft.com> From: "James Strachan" To: "Jakarta Commons Developers List" References: <103959033901@202.157.159.2> Subject: Re: [Jelly] JellyServlet Date: Mon, 16 Dec 2002 16:26:14 -0000 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1106 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1106 X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Hi Kelvin Any chance you could resend your patch by using the command cvs diff -u File >> patch.txt http://jakarta.apache.org/commons/patches.html I'll just help me be able to apply it. James ------- http://radio.weblogs.com/0112098/ ----- Original Message ----- From: "Kelvin Tan" To: "Jakarta Commons Developers List" Sent: Wednesday, December 11, 2002 6:46 AM Subject: Re: [Jelly] JellyServlet James, On Mon, 9 Dec 2002 15:18:21 -0000, James Strachan said: >Thanks for the patch Kelvin, I've committed it to CVS. > >I made a minor patch so that the URI itself could denote the script >to run. >So you could just run http://localhost:8080/foo/index.jelly for >example, rather than requiring a template=index.jelly query >parameter.. That's nice. I have changed the parameter "template" to "script". Its just that I'm so used to using Velocity. The patch you made uses getServletPath, which returns the url of the servlet being called. I've changed it to getPathInfo. Another thing. Is it really appropriate to require all scripts to be located beneath the web app's context root (which getResource does)? The previous impl using new File(script).getUrl had no such limitation... > >Some thoughts for further improvement could be... > >* implement a JellyServletContext so that the getResource() method >will use the ServletContext.getResource() method and allow access of >relative URIs when performing 's. done. > >* have a parent JellyServletContext to allow access to the >initParams of the ServletContext via variable expressions > ? >* implement the JSTL mappings of request parameters, session >parameters, cookies etc in the expression language. > >* it'd be nice to have a cache of Jelly Scripts to avoid parsing >them each time! :-) > Here's something which is a little surprise. So it means Jelly is not internally caching scripts? This has some implications for usage of Jelly as a templating subsystem for high-load systems, I imagine. In any event, perhaps it would be a better idea to cache at the engine level, rather than the servlet level, no? See attached for patch to JellyServlet and JellyServletContext. Regards, Kelvin -------- The book giving manifesto - http://how.to/sharethisbook ---------------------------------------------------------------------------- ---- > -- > To unsubscribe, e-mail: > For additional commands, e-mail: __________________________________________________ Do You Yahoo!? Everything you'll ever need on one web page from News and Sport to Email and Music Charts http://uk.my.yahoo.com -- To unsubscribe, e-mail: For additional commands, e-mail: