commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Colebourne" <scolebou...@btopenworld.com>
Subject Re: [collections] LoopingIterator
Date Thu, 14 Nov 2002 23:49:59 GMT
Jonathan,
I was going to include your files in the CVS. However, I discovered that
they do not cope with the situation where the collection being wrapped is
altered. ie. hasNext() always returns the initially cached value, even if
the list is clear()ed or it.remove() is called. Can you sort this?

Also, if resubmitting could you place the code in the correct package and
with an Apache licence (from another collections file) to confirm that this
is an official donation of code :-)

Thanks
Stephen

----- Original Message -----
From: "Jonathan Carlson" <joncrlsn2@yahoo.com>
> It is attached with updated unit tests.  It was so easy
> that I'm surprised I didn't implement the remove() in the
> first place.
>
> Thanks!
>
> Jonathan Carlson
> Minneapolis, Minnesota
>
>
> --- Stephen Colebourne <scolebourne@btopenworld.com> wrote:
> > From: "Jonathan Carlson" <joncrlsn2@yahoo.com>
> > > I can add a remove method and test cases unless it's
> > easier
> > > for you to just add it.  I think it would just use the
> > > remove method on the Collection.  If the iterator
> > returned
> > > by the Collection implementer doesn't support it then
> > this
> > > won't either.
> >
> > If you could submit the revised code and test case, I
> > think that I'm willing
> > to commit it to collections.
> >
> > Stephen
> >
> >
> > > As for a use-case, I am using it for a displaying a
> > number
> > > of our banner ads on our e-commerce site.  The
> > round-robin
> > > task dispatcher mentioned earlier is another one.
> > >
> > > Jonathan Carlson
> > >
> > >
> > >
> > > --- Stephen Colebourne <scolebourne@joda.org> wrote:
> > > > [Jonathan, I have sent back to commons-dev mailing
> > list
> > > > which is the
> > > > appropriate place for design/code discussions.]
> > > >
> > > > I took a quick look, and I believe that the code in
> > the
> > > > zip will work.
> > > > However, my main concern is why this would be needed.
> > Is
> > > > there a use case
> > > > for an iterator that never ends?
> > > >
> > > > I would also like to see the remove method
> > implemented.
> > > > It should be
> > > > possible.
> > > >
> > > > Stephen
> > > >
> > > > ----- Original Message -----
> > > > From: "Jonathan Carlson" <joncrlsn2@yahoo.com>
> > > > To: <scolebourne@joda.org>
> > > > Sent: Friday, October 18, 2002 3:53 PM
> > > > Subject: LoopingIterator
> > > >
> > > >
> > > > > Hi Stephen,
> > > > >
> > > > > Thanks for your work on the IteratorUtils.  I
> > thought
> > > > this
> > > > > might be a good addition if it hasn't been added
> > > > already.
> > > > > It's an iterator that loops continually.
> > > > Unfortunately, it
> > > > > can't just decorate another iterator but has to
> > wrap a
> > > > > collection due to the fact that iterators cannot be
> > > > reset
> > > > > to the beginning of the collection.
> > > > >
> > > > > Included is a jUnit test case that shows it works
> > "as
> > > > > advertised".  Hope this helps.
> > > > >
> > > > > Jonathan Carlson
> > > > > Minneapolis, Minnesota
> > > > >
> > > > >
> > > > > =====
> > > > > Jonathan Carlson
> > > > > joncrlsn@users.sf.net
> > > > > Minneapolis, Minnesota
> > > > >
> > > > > __________________________________________________
> > > > > Do you Yahoo!?
> > > > > Faith Hill - Exclusive Performances, Videos & More
> > > > > http://faith.yahoo.com
> > > >
> > >
> > > > ATTACHMENT part 2 application/x-zip-compressed
> > > name=LoopingIterator.zip
> > >
> > >
> > >
> > > =====
> > > Jonathan Carlson
> > > joncrlsn@users.sf.net
> > > Minneapolis, Minnesota
> > >
> > > __________________________________________________
> > > Do you Yahoo!?
> > > HotJobs - Search new jobs daily now
> > > http://hotjobs.yahoo.com/
> > >
> > > --
> > > To unsubscribe, e-mail:
> > <mailto:commons-dev-unsubscribe@jakarta.apache.org>
> > > For additional commands, e-mail:
> > <mailto:commons-dev-help@jakarta.apache.org>
> > >
> >
>
>
>
> =====
> Jonathan Carlson
> joncrlsn@users.sf.net
> Minneapolis, Minnesota
>
> __________________________________________________
> Do you Yahoo!?
> HotJobs - Search new jobs daily now
> http://hotjobs.yahoo.com/


----------------------------------------------------------------------------
----


> --
> To unsubscribe, e-mail:
<mailto:commons-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail:
<mailto:commons-dev-help@jakarta.apache.org>


--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>


Mime
View raw message