Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@apache.org Received: (qmail 34306 invoked from network); 6 Oct 2002 17:46:26 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 6 Oct 2002 17:46:26 -0000 Received: (qmail 27038 invoked by uid 97); 6 Oct 2002 17:47:11 -0000 Delivered-To: qmlist-jakarta-archive-commons-dev@jakarta.apache.org Received: (qmail 26997 invoked by uid 97); 6 Oct 2002 17:47:09 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 26985 invoked by uid 98); 6 Oct 2002 17:47:08 -0000 X-Antivirus: nagoya (v4218 created Aug 14 2002) From: Steve Downey To: commons-dev@jakarta.apache.org Subject: [collections][PATCH] CollectionUtils unused variable Date: Sun, 6 Oct 2002 13:43:32 -0400 User-Agent: KMail/1.4.1 MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="------------Boundary-00=_KKMKUWT2NFW6I1ANEXL4" Message-Id: <200210061343.32966.steve.downey@netfolio.com> X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N --------------Boundary-00=_KKMKUWT2NFW6I1ANEXL4 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable In isSubCollection(), there is a List that's new'd but never used.=20 --------------Boundary-00=_KKMKUWT2NFW6I1ANEXL4 Content-Type: text/x-diff; charset="us-ascii"; name="CollectionUtils-unused-variable.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="CollectionUtils-unused-variable.patch" Index: ./src/java/org/apache/commons/collections/CollectionUtils.java =================================================================== RCS file: /home/cvspublic/jakarta-commons/collections/src/java/org/apache/commons/collections/CollectionUtils.java,v retrieving revision 1.16 diff -u -w -r1.16 CollectionUtils.java --- ./src/java/org/apache/commons/collections/CollectionUtils.java 7 Sep 2002 19:49:49 -0000 1.16 +++ ./src/java/org/apache/commons/collections/CollectionUtils.java 6 Oct 2002 17:43:26 -0000 @@ -255,7 +255,6 @@ * @see Collection#containsAll */ public static boolean isSubCollection(final Collection a, final Collection b) { - ArrayList list = new ArrayList(); Map mapa = getCardinalityMap(a); Map mapb = getCardinalityMap(b); Iterator it = a.iterator(); --------------Boundary-00=_KKMKUWT2NFW6I1ANEXL4 Content-Type: text/plain; charset=us-ascii -- To unsubscribe, e-mail: For additional commands, e-mail: --------------Boundary-00=_KKMKUWT2NFW6I1ANEXL4--