Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@apache.org Received: (qmail 86498 invoked from network); 19 Oct 2002 23:01:39 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 19 Oct 2002 23:01:39 -0000 Received: (qmail 27864 invoked by uid 97); 19 Oct 2002 23:02:31 -0000 Delivered-To: qmlist-jakarta-archive-commons-dev@jakarta.apache.org Received: (qmail 27848 invoked by uid 97); 19 Oct 2002 23:02:30 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 27836 invoked by uid 98); 19 Oct 2002 23:02:30 -0000 X-Antivirus: nagoya (v4218 created Aug 14 2002) Message-ID: <009c01c277c3$856aeb20$3f6527d9@oemcomputer> From: "Stephen Colebourne" To: "Jakarta Commons Developers List" References: Subject: Re: [general] checkstyle report Date: Sun, 20 Oct 2002 00:01:55 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4133.2400 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400 X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N I would certainly support setting these two things at the commons level. But beyond that I would reckon that sticking with the checkstyle defaults is about right. Over time, I reckon the projects will slowly fall into line. Stephen ----- Original Message ----- From: "John Keyes" To: "Jakarta Commons Developers List" Sent: Saturday, October 19, 2002 11:54 PM Subject: Re: [general] checkstyle report > I know about how to fix these but what I was asking was > was a more general topic. As a good deal of the commons > projects inherit the POM from the CVS root I was wondering > if it would be a good idea to have a the checkstyle properties > set at this level also so all of the 'mavenized' projects pick > up the same settings. > > I think this mail is perhaps a bit more coherent ;) > > -John K > > On Saturday, Oct 19, 2002, at 23:47 Europe/Dublin, Stephen Colebourne > wrote: > > > On lang, changing the line length to 120 helped a lot. Also, I don't > > know if > > maven is on checkstyle 2.4, but if so it has a setting to deal with > > RuntimeException throws clauses in javadoc correctly which should be > > set > > > > Stephen > > > > ----- Original Message ----- > > From: "John Keyes" > > To: "Jakarta Commons Developers List" > > Sent: Saturday, October 19, 2002 11:29 PM > > Subject: Re: [general] checkstyle report > > > > > >> Yeap I'm on about the maven checkstyle report. > >> -John K > >> > >> On Saturday, Oct 19, 2002, at 23:24 Europe/Dublin, Stephen Colebourne > >> wrote: > >> > >>> Are you talking about the maven checkstyle report? Or a specific > >>> projects? > >>> Stephen > >>> > >>> ----- Original Message ----- > >>> From: "John Keyes" > >>>> I would be interested to hear people's opinions on the resolution > >>>> of checkstyle's error reporting. There are two options, one is to > >>>> correct the code style so it conforms to the checkstyle settings, > >>>> the other is to modify the settings to be less stringent. > >>>> > >>>> IMO, it would be great to have a common style across commons. > >>>> I do think there would be opposition if this became a requirement > >>>> though so I think relaxing the checkstyle properties is probably > >>>> the way to go. > >>>> > >>>> What do others think? > >>>> > >>>> -John K > >>>> > >>>> > >>>> -- > >>>> To unsubscribe, e-mail: > >>> > >>>> For additional commands, e-mail: > >>> > >>>> > >>> > >>> > >>> -- > >>> To unsubscribe, e-mail: > >>> > >>> For additional commands, e-mail: > >>> > >>> > >> > >> > >> -- > >> To unsubscribe, e-mail: > > > >> For additional commands, e-mail: > > > >> > > > > > > -- > > To unsubscribe, e-mail: > > > > For additional commands, e-mail: > > > > > > > -- > To unsubscribe, e-mail: > For additional commands, e-mail: > -- To unsubscribe, e-mail: For additional commands, e-mail: