commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael A. Smith" <...@apache.org>
Subject RE: cvs commit: jakarta-commons-sandbox/vfs/src/java/org/apache/commons/vfs/util Messages.java
Date Wed, 23 Oct 2002 14:01:22 GMT
On Wed, 23 Oct 2002, Adam Murdoch wrote:
> > >   -    public JarFileObject( FileName name,
> > >   -                          ZipEntry entry,
> > >   -                          ZipFile zipFile,
> > >   -                          JarFileSystem fs )
> > >   +    public JarFileObject( final FileName name,
> > >   +                          final ZipEntry entry,
> > >   +                          final ZipFile zipFile,
> > >   +                          final JarFileSystem fs )
> > >        {
> > >            super( name, entry, zipFile, fs );
> > >        }
> > 
> > checkstyle was complaining about that?
> 
> Uh, no.  I added the finals out of habit.

ok.  just wondering.  :)

> > >   @@ -70,7 +70,7 @@
> > >    public class Messages
> > >    {
> > >        /** Map from message code to MessageFormat object for 
> > the message. */
> > >   -    private static final Map messages = new HashMap();
> > >   +    private static Map messages = new HashMap();
> > >        private static ResourceBundle resources;
> > >    
> > >        private Messages()
> > 
> > checkstyle was complaining about that?
> 
> Yep.  It wanted
> 
> private static final Map MESSAGES = new HashMap();
> 
> I prefered to get rid of the final.

ah...  makes sense (even though you already had what you say it wanted 
-- it probably wanted private final static or final private static or 
something in a different order).  :)

regards,
michael

-- 
Michael A. Smith
mas@apache.org


--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>


Mime
View raw message