Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@apache.org Received: (qmail 12606 invoked from network); 2 Sep 2002 13:34:53 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 2 Sep 2002 13:34:53 -0000 Received: (qmail 27952 invoked by uid 97); 2 Sep 2002 13:35:24 -0000 Delivered-To: qmlist-jakarta-archive-commons-dev@jakarta.apache.org Received: (qmail 27903 invoked by uid 97); 2 Sep 2002 13:35:23 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 27891 invoked by uid 98); 2 Sep 2002 13:35:23 -0000 X-Antivirus: nagoya (v4218 created Aug 14 2002) Message-ID: <3D7368E4.6080402@gmx.de> Date: Mon, 02 Sep 2002 15:34:28 +0200 From: Christopher Lenz User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.0.0) Gecko/20020530 X-Accept-Language: en MIME-Version: 1.0 To: Jakarta Commons Developers List Subject: Re: [Digester] Namespacesupport, Patch References: <20020901140809.GA2415@honk> <3D736072.9010903@gmx.de> <20020902131812.GA2749@honk> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Stefan Heimann wrote: > On Mon, Sep 02, 2002 at 02:58:26PM +0200, Christopher Lenz wrote: > >>Hi Stefan, >> >>Stefan Heimann wrote: >> >>>Hi all, >>> >>>as posted earlier, here is the patch that adds support for rules that >>>can match element in different namespaces. For example, its possible >>>the have a pattern ``/foo:a/bar:b'' that matches >> >>[...] >> >>>I have updated the matching behaviour of RulesBase and >>>ExtendedBaseRules. The matching semantic did not change, there are >>>only some more possibilities. >> >>While I would love to see the functionality you've added in Digester, I >>think the change should be done with more care. > > > Could you describe more exactly what you mean by ``with more care''? Maybe that sounded too harsh, I didn't want to express that the code was not good or anything ;o) My basic concern is that you're proposing backwards incompatible API changes just to replace the pattern-String with a QNameList (IIRC). My suggestion is to replace it with a more generic class that represents the input document context (I've called it DigesterContext in my example). The reasoning for this is that it allows further extension, like matching against attributes or body text. For example, the DigesterContext implementation could be made pluggable to allow real document object models that enable full-blown XPath pattern matching. Of course that's an extreme example, what I want to express is that if the API is changed, it should be done with further extensions in mind. I've posted my PROPOSAL a couple of minutes ago, maybe you wanna read it (but it's looooooooong ;o)) -- Christopher Lenz /=/ cmlenz at gmx.de -- To unsubscribe, e-mail: For additional commands, e-mail: