Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@apache.org Received: (qmail 91750 invoked from network); 17 Sep 2002 23:38:02 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 17 Sep 2002 23:38:02 -0000 Received: (qmail 13361 invoked by uid 97); 17 Sep 2002 23:38:44 -0000 Delivered-To: qmlist-jakarta-archive-commons-dev@jakarta.apache.org Received: (qmail 13329 invoked by uid 97); 17 Sep 2002 23:38:44 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 29491 invoked by uid 98); 17 Sep 2002 23:11:48 -0000 X-Antivirus: nagoya (v4218 created Aug 14 2002) Content-Type: text/plain; charset="iso-8859-1" From: Janek Bogucki Reply-To: yan@studylink.com To: "Jakarta Commons Developers List" Subject: Re: [latka] [PATCH] RequestImpl.setVersion () throws NPE Date: Wed, 18 Sep 2002 00:11:01 +0000 X-Mailer: KMail [version 1.2] References: <02091711071400.00901@bogucki.demon.co.uk> In-Reply-To: MIME-Version: 1.0 Message-Id: <02091800110101.01353@bogucki.demon.co.uk> Content-Transfer-Encoding: 8bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Tuesday 17 September 2002 10:09 pm, Daniel Rall wrote: > Janek Bogucki writes: > > Index: RequestImpl.java > > =================================================================== > > RCS file: > > /home/cvspublic/jakarta-commons/latka/src/java/org/apache/commons/latka/h > >ttp/RequestImpl.java,v retrieving revision 1.29 > > diff -u -r1.29 RequestImpl.java > > --- RequestImpl.java 4 Sep 2002 02:59:26 -0000 1.29 > > +++ RequestImpl.java 17 Sep 2002 09:49:56 -0000 > > @@ -511,8 +511,10 @@ > > * @param version HTTP version > > */ > > public void setVersion(String version) { > > - if (version.equals(HTTP_10)) { > > + if (HTTP_10.equals(version)) { > > ((HttpMethodBase) _httpMethod).setHttp11(false); > > + } else { > > + ((HttpMethodBase) _httpMethod).setHttp11(true); > > } > > } > > } > > I generally prefer the more brief style: > > ((HttpMethodBase) _httpMethod).setHttp11(!HTTP_10.equals(version)); > Can you apply your compact version to the CVS source and remove my patch from buzilla? Thanks, Janek Bogucki -- To unsubscribe, e-mail: For additional commands, e-mail: