commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d...@multitask.com.au
Subject Re: [latka] [PATCH] RequestImpl.setVersion () throws NPE
Date Thu, 26 Sep 2002 00:53:45 GMT
Patch has been applied and tests have passed except test status codes 
which fails on the GoodURL test. I'm behind a firewall, so that may be the 
problem.

Am investigating
--
dIon Gillard, Multitask Consulting
Work:      http://www.multitask.com.au
Developers: http://adslgateway.multitask.com.au/developers


dlr@finemaltcoding.com wrote on 25/09/2002 03:01:10 PM:

> Janek Bogucki <yan@studylink.com> writes:
> 
> > On Tuesday 17 September 2002 10:09 pm, Daniel Rall wrote:
> > > Janek Bogucki <yan@studylink.com> writes:
> > > > Index: RequestImpl.java
> > > > 
===================================================================
> > > > RCS file:
> > > > /home/cvspublic/jakarta-
> commons/latka/src/java/org/apache/commons/latka/h
> > > >ttp/RequestImpl.java,v retrieving revision 1.29
> > > > diff -u -r1.29 RequestImpl.java
> > > > --- RequestImpl.java   4 Sep 2002 02:59:26 -0000   1.29
> > > > +++ RequestImpl.java   17 Sep 2002 09:49:56 -0000
> > > > @@ -511,8 +511,10 @@
> > > >       * @param version  HTTP version
> > > >       */
> > > >      public void setVersion(String version) {
> > > > -        if (version.equals(HTTP_10)) {
> > > > +        if (HTTP_10.equals(version)) {
> > > >              ((HttpMethodBase) _httpMethod).setHttp11(false);
> > > > +        } else {
> > > > +            ((HttpMethodBase) _httpMethod).setHttp11(true);
> > > >          }
> > > >      }
> > > >  }
> > >
> > > I generally prefer the more brief style:
> > >
> > >   ((HttpMethodBase) 
_httpMethod).setHttp11(!HTTP_10.equals(version));
> > >
> > 
> > Can you apply your compact version to the CVS source and remove my
> > patch from buzilla?
> 
> Janek, I'll leave it to an existing latka commiter.  I updated the
> Bugzilla report accordingly.
> -- 
> 
> Daniel Rall <dlr@finemaltcoding.com>
> 
> --
> To unsubscribe, e-mail: 
<mailto:commons-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: 
<mailto:commons-dev-help@jakarta.apache.org>
> 


--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>


Mime
View raw message