commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ortwin Gl├╝ck" <>
Subject Re: [httpclient][patch] StatusLine encapsulation
Date Wed, 04 Sep 2002 08:31:47 GMT
All very nice. And it's compatible with existing code.

My critizism is only cosmetics: you can ommit the call to super() in the 
constructor (it's always done automatically).

Jeff Dever wrote:
> This is my response for the bug:
> I added a new StatusLine class and added it as an instance variable to
> HttpMethodBase.  Removed individual statusCode and statusText members.
> Removed the parsing of the status line into the StatusLine constructor.
> HttpMethodBase.readStatusLine() still checks for the http version and
> sets the (dreaded) isHttp11 boolean.  There was an interface change to
> the HttpMethod interface to getStatusLine().
> I like this solution as it get some of the code out of HttpMethodBase
> and recognizes the uniqueness of the Status-Line.
> What do ya'll think?
> PS: This is based on a suggestion by Vincent Massol.

To unsubscribe, e-mail:   <>
For additional commands, e-mail: <>

View raw message