Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@apache.org Received: (qmail 34079 invoked from network); 21 Aug 2002 20:23:36 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 21 Aug 2002 20:23:36 -0000 Received: (qmail 8421 invoked by uid 97); 21 Aug 2002 20:23:51 -0000 Delivered-To: qmlist-jakarta-archive-commons-dev@jakarta.apache.org Received: (qmail 8351 invoked by uid 97); 21 Aug 2002 20:23:50 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 8313 invoked by uid 98); 21 Aug 2002 20:23:49 -0000 X-Antivirus: nagoya (v4218 created Aug 14 2002) From: Ola Berg To: commons-dev@jakarta.apache.org Reply-To: Ola Berg MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 8bit User-Agent: Tripnet Webmail (IMP/PHP) Sender: ola.berg@arkitema.se Subject: [commons]NPE or IAE? Message-Id: Date: Wed, 21 Aug 2002 22:23:17 +0200 X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N A quickie. When contributing new code directly to Commons, would you like me to use IllegalArgumentException for all illegal arguments to a method, or NullPointerException for the illegal nulls? This question goes out to 1) all Commons, since this is fresh code in Commons 2) io, since the particular class is in io 3) lang, since it works closely with lang Preferences, anybody? Personally, I prefer IAE, since that leaves me with only one exception to throw for all illegal arguments, regardless of cause. Putting the right value in a parameter is something you do in order to maintain consistency, avoiding NPE and other runtime exceptions. IMO. Second: there was a thread on coding conventions lately. I wonder if it would be a benefit if questions like these (such as naming conventions: XxxUtils/Xxxs, when to use toXxx and when to use asXxx etc) could be answered in a \"prefered style\" document: a non binding style guide that reflects the most popular styles of the committers, or lists the acceptable styles (sorted in order of preference maybe)? IIRC, XxxUtils was favored over Xxxs by the majority, but was that documented (elsewhere than in the mails)? In a document where the answer to the NPE/IAE question should go too? /O -------------------- ola.berg@arkitema.se 0733 - 99 99 17 -- To unsubscribe, e-mail: For additional commands, e-mail: