Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@apache.org Received: (qmail 20819 invoked from network); 21 Aug 2002 11:47:25 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 21 Aug 2002 11:47:25 -0000 Received: (qmail 20228 invoked by uid 97); 21 Aug 2002 11:47:50 -0000 Delivered-To: qmlist-jakarta-archive-commons-dev@jakarta.apache.org Received: (qmail 20212 invoked by uid 97); 21 Aug 2002 11:47:49 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 20201 invoked by uid 97); 21 Aug 2002 11:47:49 -0000 X-Antivirus: nagoya (v4218 created Aug 14 2002) Date: 21 Aug 2002 11:47:18 -0000 Message-ID: <20020821114718.53431.qmail@icarus.apache.org> From: jstrachan@apache.org To: jakarta-commons-cvs@apache.org Subject: cvs commit: jakarta-commons/discovery/src/java/org/apache/commons/discovery ServiceDiscovery.java ServiceDiscoveryTask.java X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N jstrachan 2002/08/21 04:47:18 Modified: discovery/src/java/org/apache/commons/discovery ServiceDiscovery.java ServiceDiscoveryTask.java Log: Now deprecated the getServiceDiscovery() method on ServiceDiscovery. Now using a static newInstance() instead which follows the JAXP naming conventions, and makes it more clear that its not returning a singleton. Revision Changes Path 1.2 +15 -1 jakarta-commons/discovery/src/java/org/apache/commons/discovery/ServiceDiscovery.java Index: ServiceDiscovery.java =================================================================== RCS file: /home/cvs/jakarta-commons/discovery/src/java/org/apache/commons/discovery/ServiceDiscovery.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- ServiceDiscovery.java 17 Aug 2002 06:36:11 -0000 1.1 +++ ServiceDiscovery.java 21 Aug 2002 11:47:18 -0000 1.2 @@ -87,6 +87,7 @@ * @author Richard A. Sitze * @author Craig R. McClanahan * @author Costin Manolache + * @author James Strachan */ public abstract class ServiceDiscovery { @@ -99,10 +100,23 @@ protected ServiceDiscovery() { } - public static ServiceDiscovery getServiceDiscovery() { + /** + * Creates a new instance of a ServiceDiscovery instance based on the + * abilities of the current JDK. The later the JDK the neater the implementation + * of service discovery. + * ServiceDiscovery12 will be used on JDK 1.2 or later JDKs. + */ + public static ServiceDiscovery newInstance() { // This is _not_ singleton. return new ServiceDiscovery12(); // XXX Check if JDK1.1 is used and return the specific version + } + + /** + * @deprecated please now use {@link #newInstance()} + */ + public static ServiceDiscovery getServiceDiscovery() { + return newInstance(); } /** Specify a new class loader to be used in searching. 1.2 +1 -1 jakarta-commons/discovery/src/java/org/apache/commons/discovery/ServiceDiscoveryTask.java Index: ServiceDiscoveryTask.java =================================================================== RCS file: /home/cvs/jakarta-commons/discovery/src/java/org/apache/commons/discovery/ServiceDiscoveryTask.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- ServiceDiscoveryTask.java 17 Aug 2002 06:36:11 -0000 1.1 +++ ServiceDiscoveryTask.java 21 Aug 2002 11:47:18 -0000 1.2 @@ -93,7 +93,7 @@ public void execute() throws Exception { System.out.println("XXX "); - ServiceDiscovery disc=ServiceDiscovery.getServiceDiscovery(); + ServiceDiscovery disc=ServiceDiscovery.newInstance(); disc.addClassLoader( disc.getThreadClassLoader() ); disc.addClassLoader( this.getClass().getClassLoader() ); -- To unsubscribe, e-mail: For additional commands, e-mail: