commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d...@multitask.com.au
Subject Re: [HttpClient][PATCH] Correction to Location header check logic
Date Sun, 01 Sep 2002 02:43:48 GMT
Applied,

thanks again
--
dIon Gillard, Multitask Consulting
Work:      http://www.multitask.com.au
Developers: http://adslgateway.multitask.com.au/developers


Ryan Lubke <Ryan.Lubke@Sun.COM> wrote on 29/08/2002 12:53:36 AM:

> The current logic is causing several tests to fail when run against 
> Tomcat:
> 
> ------------------------------------------------------------
> //get the location header to find out where to redirect to
> Header locationHeader = getResponseHeader("location");
>  if (locationHeader != null) {
>    // got a redirect response, but no location header
>    log.error("Received redirect response " + statusCode + " but no
> location header");
>    return statusCode;
> }
> -------------------------------------------------------------
> The check should not be '!=' but '=='.
> 
> The attached patch corrects the issue and includes the fix
> for the NPE issue I reported previously.
> 
> 
> 
> [attachment "HttpMethodBase.patch" removed by dIon Gillard/Multitask
> Consulting/AU] --
> To unsubscribe, e-mail: 
<mailto:commons-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: 
<mailto:commons-dev-help@jakarta.apache.org>

--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>


Mime
View raw message