commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robert burrell donkin <robertdon...@mac.com>
Subject Re: [PATCH] Error with the digester-rules.dtd
Date Fri, 23 Aug 2002 13:47:16 GMT
patch applied. many thanks.

the next time you submit a patch could you please ensure that you use 
spaces rather than tabs for indentation. i've gone through and changed 
them back again but that's for this time only.

- robert

On Friday, August 23, 2002, at 09:47 AM, David WIlkinson wrote:

> Hi
>
> Sorry about that I'am new to CVS, the attached file include the original
> patches as well as tests.
>
> A bigger description is that the dtd file digester-rules.dtd contained a
> few invalid characters in the definition of a few attributes.
>
> Also the call-param-rule was not being setup correctly which had the
> effect that the method defined by the corresponding call-method-rule is
> called with null parameters. The error has been raised as error 11168
> under bugzilla
>
> DRAW
>
> -----Original Message-----
> From: robert burrell donkin
> [mailto:robertburrelldonkin@blueyonder.co.uk]
> Sent: 22 August 2002 22:38
> To: Jakarta Commons Developers List
> Subject: Re: [PATCH] Error with the digester-rules.dtd
>
> hi david
>
> could you repost both your patches using cvs diff -u?
>
> (it's the standard here at jakarta and it'd make my life a lot easier.)
>
> if you have the time, a couple of test cases would also be greatly
> appreciated. if you haven't, then a bit of a bigger description of the
> bug
> would help me to create them myself.
>
> TIA
>
> - robert
>
> On Wednesday, August 21, 2002, at 05:28 PM, David WIlkinson wrote:
>
>> cvs diff -w -i digester-rules.dtd (in directory
>>
> D:\CVS\jakarta-commons\digester\src\java\org\apache\commons\digester\xml
>> rules\)
>> Index: digester-rules.dtd
>> ===================================================================
>> RCS file:
>>
> /home/cvspublic/jakarta-commons/digester/src/java/org/apache/commons/dig
>> ester/xmlrules/digester-rules.dtd,v
>> retrieving revision 1.4
>> diff -w -i -r1.4 digester-rules.dtd
>> 106,107c106,107
>> < ÊÊÊÊ attr-name CDATA #REQUIRED
>> < ÊÊÊÊ prop-name CDATA #IMPLIED>
>> ---
>>>  attr-name CDATA #REQUIRED
>>>  prop-name CDATA #IMPLIED>
>>
>>
>
>
> --
> To unsubscribe, e-mail:
> <mailto:commons-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail:
> <mailto:commons-dev-help@jakarta.apache.org>
>
>
>  --
> To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.
> org>
> For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.
> org>


--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>


Mime
View raw message