commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Waldhoff, Rodney" <rwald...@us.britannica.com>
Subject FW: [Collections] primitive pkg - was "Release potential?"
Date Mon, 19 Aug 2002 22:31:59 GMT
Sorry if you get this twice, I didn't see this come back via the list.

-----Original Message-----
From: Waldhoff, Rodney
To: 'Jack, Paul '; ''Jakarta Commons Developers List' '
Sent: 8/19/2002 4:27 PM
Subject: RE: [Collections] primitive pkg - was "Release potential?"

-1, for the reasons I just described.

-----Original Message-----
From: Jack, Paul
To: 'Jakarta Commons Developers List'
Sent: 8/19/2002 4:20 PM
Subject: RE: [Collections] primitive pkg - was "Release potential?"

I've renamed Abstract*ArrayList to Abstract*List.  Good catch.

Also, you use cvs to create a patch file, not patch (patch is 
just to apply the patch.)

The cvs invocation is:

cvs diff -u <filename>

-Paul

> -----Original Message-----
> From: Jonathan Carlson [mailto:joncrlsn2@yahoo.com]
> Sent: Monday, August 19, 2002 1:15 PM
> To: Jakarta Commons Developers List
> Subject: RE: [Collections] primitive pkg - was "Release potential?"
> 
> 
> > ...and I'm not sure what a better name would be for a 
> > list backed by an int array.
> 
> I can understand that rational for the naming of
> IntArrayList and can live with it if the class doc was
> better.  (I'm having trouble creating a patch file with
> better docs, though.  The Cygwin patch man page seems to be
> geared towards applying patch files, not the other way
> around.)
> 
> However, as you argue, the AbstractIntArrayList also
> implies  an implementation of an array when it doesn't
> require that at all.  I would greatly prefer
> "AbstractIntList", (ditto for the other Abstract*List
> classes: long, short, float, etc) which would open the door
> for a similarly named IntList interface which I presume
> would extend the List interface.
> 
> Jonathan
> 
> 
> > not
> > sure what a better name would be for a list backed by an
> > int array.  Did you have something else in mind?
> 
> --- "Jack, Paul" <pjack@sfaf.org> wrote:
> > > I'm sorry to bring these things up at a rather late
> > date
> > > but I guess it's better now than after the release.
> > 
> > Well, yes and no.  Things that can't be changed after the
> > release should be addressed now.  Things that can be
> > added
> > later should be, IMO, because there are people seriously
> > waiting on a new Collections release, and I wouldn't want
> > to rush new features.
> > 
> > In your list here, #2 must be addressed immediately.  #1
> > can be without hurting anything, so if you've got the 
> > patches, by all means submit them.  But #3 would require
> > much thought as to what goes into the interface (can't
> > add new methods later) so I'd prefer to defer it until
> > after the release.  The existing classes can always 
> > implement a new interface without breaking backwards
> > compatibility.
> > 
> > Regarding #2, I'm not sure I agree with you.  Whereas
> > yes,
> > the term "ArrayList" implies that it subclasses
> > ArrayList,
> > the JavaDoc clearly indicates that it doesn't, and I'm
> > not
> > sure what a better name would be for a list backed by an
> > int array.  Did you have something else in mind?
> > 
> > -Paul
> > 
> > > 
> > > 1) It would be nice to have better class documentation
> > on
> > > the "primitive" package classes.  It is unobvious to me
> > > (looking at the API) what using IntArrayList would
> > "buy" me
> > > other than no ClassCastExceptions.  Is it faster or
> > does it
> > > use less memory or something else or neither?  The API
> > > should be obvious without having to look at the code.
> > > 
> > > 2) ArrayList is a specific implementation that should
> > not
> > > be used in the name of these classes
> > (AbstractIntArrayList
> > > and IntArrayList) because it implies a certain
> > > implementation (namely the use of ArrayList or subclass
> > of
> > > it) that isn't the case.  The differences (ArrayList of
> > > Integers vs. arrays of ints) are very important in
> > terms of
> > > memory usage (see
> > >
> >
> http://www.javaworld.com/javaworld/javatips/jw-javatip130.html).
> > > 
> > > 3) I would greatly prefer to have an IntList interface
> > so I
> > > can declare variables and arguments with an interface
> > > instead of an abstract super class (like we do with the
> > > collection interfaces).  See Joshua Bloch's "Effective
> > > Java" item number 16 on page 84.  He agrees with me
> > too.
> > > 
> > > Does anyone else see this the way I do?  I'd be happy
> > to
> > > commit documentation improvements (#1), but I don't
> > think I
> > > am known enough to get approved.  (I wrote the
> > > TransformingComparator class which I think IMHO is
> > pretty
> > > well documented).
> > > 
> > > Jonathan
> > > 
> > > 
> > > --- "Jack, Paul" <pjack@sfaf.org> wrote:
> > > > > I'm a big fan of having the release notes completed
> > > > prior to 
> > > > > a release.  The release vote then is a simple
> > "these
> > > > exact 
> > > > > bits are what we are releasing" rather than some
> > > > unknown product...
> > > > 
> > > > Ok, I'll work on the release notes then.
> > > > 
> > > > 
> > > > > It seems like everything has been addressed, but
> > I'd
> > > > like to take a 
> > > > > closer look over my todo list.  Unfortunately, I
> > won't
> > > > have 
> > > > > time until at least Saturday.
> > > > 
> > > > Ok.
> > > > 
> > > >  
> > > > > Does this also mean you're volunteering to be the
> > > > release manager for 
> > > > > the release?  :)
> > > > 
> > > > I guess so.  Why not bring my compulsive obsessions
> > with
> > > > the Collections
> > > > API to their natural end...
> > > > 
> > > > -Paul
> > > > 
> > > > 
> > > > --
> > > > To unsubscribe, e-mail:  
> > > > <mailto:commons-dev-unsubscribe@jakarta.apache.org>
> > > > For additional commands, e-mail:
> > > > <mailto:commons-dev-help@jakarta.apache.org>
> > > > 
> > > 
> > > 
> > > 
> > > =====
> > > Jonathan Carlson
> > > joncrlsn@users.sf.net
> > > Minneapolis, Minnesota
> > > 
> > > __________________________________________________
> > > Do You Yahoo!?
> > > HotJobs - Search Thousands of New Jobs
> > > http://www.hotjobs.com
> > > 
> > > --
> > > To unsubscribe, e-mail:   
> > <mailto:commons-dev-unsubscribe@jakarta.apache.org>
> > For additional commands, e-mail:
> > <mailto:commons-dev-help@jakarta.apache.org>
> > 
> > --
> > To unsubscribe, e-mail:  
> > <mailto:commons-dev-unsubscribe@jakarta.apache.org>
> > For additional commands, e-mail:
> > <mailto:commons-dev-help@jakarta.apache.org>
> > 
> 
> 
> 
> =====
> Jonathan Carlson
> joncrlsn@users.sf.net
> Minneapolis, Minnesota
> 
> __________________________________________________
> Do You Yahoo!?
> HotJobs - Search Thousands of New Jobs
> http://www.hotjobs.com
> 
> --
> To unsubscribe, e-mail:   
<mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail:
<mailto:commons-dev-help@jakarta.apache.org>

--
To unsubscribe, e-mail:
<mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail:
<mailto:commons-dev-help@jakarta.apache.org>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message